net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags

2 messages, 2 authors, 2003-11-11 · open the first message on its own page

net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags

From: Ihar 'Philips' Filipau <hidden>
Date: 2003-11-10 11:10:55

Hi!

   [ I'm trying to cc: netdev - but they are not that welcome - and require subscription. I'm way too lazy (and my mail box is not that fast) to subscribe to send simple typo - if this is a case at all. ]

   [ kernel v2.6.0-test7 as found on lxr.linux.no, 2.4.{18,22} has the same - but line numbers are different. ]

   On line 1057 we have: "msg->msg_flags|=MSG_TRUNC;" to indicate that message was truncated.

   But on line 1073, where we make return status to user, we check against user suplied flags, but NOT msg->msg_flags.

   It looks like obvious typo.

-- 
Ihar 'Philips' Filipau  / with best regards from Saarbruecken.
--                                                           _ _ _
 "... and for $64000 question, could you get yourself       |_|*|_|
   vaguely familiar with the notion of on-topic posting?"   |_|_|*|
                                -- Al Viro @ LKML           |*|*|*|

Re: net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags

From: David S. Miller <hidden>
Date: 2003-11-11 07:18:44

On Mon, 10 Nov 2003 12:10:46 +0100
"Ihar 'Philips' Filipau" [off-list ref] wrote:
    On line 1057 we have: "msg->msg_flags|=MSG_TRUNC;" to indicate that 
message was truncated.

    But on line 1073, where we make return status to user, we check 
against user suplied flags, but NOT msg->msg_flags.

    It looks like obvious typo.
Indeed, you're right.

Thanks for the report, I'll fix this in both 2.4.x and 2.6.x
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help