[IPV4] Always set hoplimit

Hi Dave:

Is there any reason why local/broadcast packets should have a ttl of zero?
This is the result of the HOPLIMIT change as those packets doesn't get
their HOPLIMIT set.  This patch sets it for them.

Am I missing something?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

On Thu, 13 Nov 2003 22:04:38 +1100
Herbert Xu [off-list ref] wrote:

Is there any reason why local/broadcast packets should have a ttl of zero?
This is the result of the HOPLIMIT change as those packets doesn't get
their HOPLIMIT set.  This patch sets it for them.

Am I missing something?

I don't believe I changed this behavior intentionally.  Let me
look into the revision history to verify that.  I'm likely going
to apply your fix tonight, thanks.

Although it is an interesting question because both broadcasts and
locally destined packets have no reason to make it past the local
subnet and thus have their TTL/HOPLIMIT decremented or tested.  I
therefore cannot imagine a case where the current behavior would cause
a problem.

Did you run into an actual problem that led you to this issue?  If
so, what was it?  Or was this just determined by pure code review?

On Wed, 19 Nov 2003 12:08:27 +1100
Herbert Xu [off-list ref] wrote:

On Tue, Nov 18, 2003 at 04:59:09PM -0800, David S. Miller wrote:

quoted

Did you run into an actual problem that led you to this issue?  If
so, what was it?  Or was this just determined by pure code review?

Someone reported this problem to me after a picky firewall complained
about getting broadcast packets with ttl == 0.

Ok, that doubly-justifies the fix.

Thanks again Herbert.

On Tue, Nov 18, 2003 at 04:59:09PM -0800, David S. Miller wrote:

Did you run into an actual problem that led you to this issue?  If
so, what was it?  Or was this just determined by pure code review?

Someone reported this problem to me after a picky firewall complained
about getting broadcast packets with ttl == 0.

Cheers,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt