5 messages, 3 authors, 2003-10-12 · open the first message on its own page
From: Randy.Dunlap <hidden>
Date: 2003-10-10 21:25:48
drivers/char/toshiba.c and net/atm/clip.c don't build if PROC_FS=n. Patches for them are available at: http://developer.osdl.org/rddunlap/patches/toshiba_inline_260t7.patch http://developer.osdl.org/rddunlap/patches/atmprocfs_260t7.patch There are several other drivers/protocols that don't build with PROC_FS=n, like arlan, siimage, ipx, llc, and bluetooth. -- ~Randy
From: David S. Miller <hidden>
Date: 2003-10-11 19:14:45
On Fri, 10 Oct 2003 14:16:46 -0700 "Randy.Dunlap" [off-list ref] wrote:
http://developer.osdl.org/rddunlap/patches/atmprocfs_260t7.patch
How can this be needed? When procfs is disabled then
remove_proc_entry() is defined as "do { } while (0)", ie. a nop.
From: Sam Ravnborg <hidden>
Date: 2003-10-11 19:40:14
On Sat, Oct 11, 2003 at 12:08:52PM -0700, David S. Miller wrote:
On Fri, 10 Oct 2003 14:16:46 -0700 "Randy.Dunlap" [off-list ref] wrote:quoted
http://developer.osdl.org/rddunlap/patches/atmprocfs_260t7.patchHow can this be needed? When procfs is disabled then remove_proc_entry() is defined as "do { } while (0)", ie. a nop.
Due to this - the real offender: from: net/atm/clip.c: #ifdef CONFIG_PROC_FS #include <linux/proc_fs.h> #include <linux/seq_file.h> #endif Sam
From: David S. Miller <hidden>
Date: 2003-10-11 19:46:21
On Sat, 11 Oct 2003 21:40:08 +0200 Sam Ravnborg [off-list ref] wrote:
Due to this - the real offender: from: net/atm/clip.c: #ifdef CONFIG_PROC_FS #include <linux/proc_fs.h> #include <linux/seq_file.h> #endif
That makes a whole lot more sense, here is the fix I just checked in: # This is a BitKeeper generated patch for the following project: # Project Name: Linux kernel tree # This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas: # ChangeSet 1.1352 -> 1.1353 # net/atm/clip.c 1.26 -> 1.27 # # The following is the BitKeeper ChangeSet Log # -------------------------------------------- # 03/10/11 davem@nuts.ninka.net 1.1353 # [ATM]: Kill PROC_FS ifdef around includes. # -------------------------------------------- # diff -Nru a/net/atm/clip.c b/net/atm/clip.c
--- a/net/atm/clip.c Sat Oct 11 12:43:12 2003
+++ b/net/atm/clip.c Sat Oct 11 12:43:12 2003@@ -24,10 +24,8 @@ #include <linux/if.h> /* for IFF_UP */ #include <linux/inetdevice.h> #include <linux/bitops.h> -#ifdef CONFIG_PROC_FS #include <linux/proc_fs.h> #include <linux/seq_file.h> -#endif #include <net/route.h> /* for struct rtable and routing */ #include <net/icmp.h> /* icmp_send */ #include <asm/param.h> /* for HZ */
From: Randy.Dunlap <hidden>
Date: 2003-10-12 03:24:33
On Sat, 11 Oct 2003 21:40:08 +0200 Sam Ravnborg [off-list ref] wrote:
| On Sat, Oct 11, 2003 at 12:08:52PM -0700, David S. Miller wrote:
| > On Fri, 10 Oct 2003 14:16:46 -0700
| > "Randy.Dunlap" [off-list ref] wrote:
| >
| > > http://developer.osdl.org/rddunlap/patches/atmprocfs_260t7.patch
| >
| > How can this be needed? When procfs is disabled then
| > remove_proc_entry() is defined as "do { } while (0)", ie. a nop.
|
| Due to this - the real offender:
|
| from: net/atm/clip.c:
| #ifdef CONFIG_PROC_FS
| #include <linux/proc_fs.h>
| #include <linux/seq_file.h>
| #endif
ugh, thanks.
--
~Randy