Hi guys,
I noticed ip6_append_data() always reserves space for the fragment header
at the cost of the payload data. This leads to the unnecessary
fragmentation of packets with lengths close (or equal) to the link-mtu.
This can for example be seen with ping6 -s 1448 (on an ethernet link).
My attached patch _seems_ to fix the problem without breaking anything
else, but can you still verify this?
Thanks,
Ville
--
Ville Nuorvala
Research Assistant, Institute of Digital Communications,
Helsinki University of Technology
email: vnuorval@tcs.hut.fi, phone: +358 (0)9 451 5257
In article [off-list ref] (at Wed, 6 Aug 2003 13:00:41 +0300 (EEST)), Ville Nuorvala [off-list ref] says:
I noticed ip6_append_data() always reserves space for the fragment header
at the cost of the payload data. This leads to the unnecessary
fragmentation of packets with lengths close (or equal) to the link-mtu.
This can for example be seen with ping6 -s 1448 (on an ethernet link).
My attached patch _seems_ to fix the problem without breaking anything
else, but can you still verify this?
Well, your patch breaks something; the idea of append_data.
User may "push" multiple times to generate a packet.
I'm chasing this bug.
Since this bug is not grave, we do not need to fix this ASAP;
We need to fix a grave issue with UDPv6 with MSG_MORE flag
before this.
--
Hideaki YOSHIFUJI @ USAGI Project [off-list ref]
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
On Wed, 6 Aug 2003, YOSHIFUJI Hideaki / [iso-2022-jp] $B5HF#1QL@(B wrote:
Well, your patch breaks something; the idea of append_data.
User may "push" multiple times to generate a packet.
Yeah, I thought there might be something like this, since I'm not yet that
familiar with the new fragmentation code. :)
I'm chasing this bug.
Since this bug is not grave, we do not need to fix this ASAP;
We need to fix a grave issue with UDPv6 with MSG_MORE flag
before this.
No problem.
Regards,
Ville
--
Ville Nuorvala
Research Assistant, Institute of Digital Communications,
Helsinki University of Technology
email: vnuorval@tcs.hut.fi, phone: +358 (0)9 451 5257