RE: e100 "Ferguson" release

From: Feldman, Scott <hidden>
Date: 2003-08-05 14:28:58

quoted
if(unlikely(e100_exec_cb(nic, skb, e100_xmit_prepare) == -ENOMEM)) {
        netif_stop_queue(netdev);
        nic->net_stats.tx_dropped++;
        dev_kfree_skb(skb);
        return 0;
}
Yes.  I would also printk(KERN_ERR "we have a bug!") or 
somesuch, like several other drivers do, too.
It's there, sorry, was trying to keep the code snippet small.
quoted
quoted
* (minor) use a netif_msg_xxx wrapper/constant in
e100_init_module test?

Can't - don't have nic->msg_enable allocated yet.  :(
You could always use "(1 << debug) - 1"... :)  I dunno if it's worth 
worrying about.
(1 << debug) - 1) & NETIF_MSG_DRV is what's there now.

-scott
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help