5 messages, 3 authors, 2003-06-04 · open the first message on its own page
From: Jeff Garzik <hidden>
Date: 2003-06-03 17:45:54
For janitors and other developers placing this in net drivers... please don't :) This can be done in upper layers, accomplishing the same goal without changing the low-level net driver code at all. Jeff
From: David S. Miller <hidden>
Date: 2003-06-04 02:58:22
From: Jeff Garzik [off-list ref] Date: Tue, 3 Jun 2003 13:59:21 -0400 For janitors and other developers placing this in net drivers... please don't :) This can be done in upper layers, accomplishing the same goal without changing the low-level net driver code at all. Don't say something can be done without showing exactly how :-) How does register_netdevice() know that the device is "whatever" and where to get the generic device struct from?
From: Jeff Garzik <hidden>
Date: 2003-06-04 03:14:27
David S. Miller wrote:
From: Jeff Garzik [off-list ref] Date: Tue, 3 Jun 2003 13:59:21 -0400 For janitors and other developers placing this in net drivers... please don't :) This can be done in upper layers, accomplishing the same goal without changing the low-level net driver code at all. Don't say something can be done without showing exactly how :-) How does register_netdevice() know that the device is "whatever" and where to get the generic device struct from?
Doh! You are totally right -- it can't get the association any other way. Folks, ignore me :) Jeff
From: Stephen Hemminger <hidden>
Date: 2003-06-04 03:31:51
David S. Miller wrote:
From: Jeff Garzik [off-list ref] Date: Tue, 3 Jun 2003 13:59:21 -0400 For janitors and other developers placing this in net drivers... please don't :) This can be done in upper layers, accomplishing the same goal without changing the low-level net driver code at all. Don't say something can be done without showing exactly how :-) How does register_netdevice() know that the device is "whatever" and where to get the generic device struct from?
There are enough PCI network devices, that something like alloc_pci_etherdev might be a good future idea.
From: David S. Miller <hidden>
Date: 2003-06-04 03:34:51
From: Stephen Hemminger [off-list ref] Date: Tue, 03 Jun 2003 20:45:21 -0700 There are enough PCI network devices, that something like alloc_pci_etherdev might be a good future idea. What is sos special about PCI? :-) In this light, alloc_device_etherdev() seems much more appropriate. But we can play this game AD_INFINITUM, for each and every paramter that is common across a class of ethernet devices. At what point do you stop? :-)