[PATCH] missing owner field entry on pppoe /proc

STALE8518d

2 messages, 2 authors, 2003-06-19 · open the first message on its own page

[PATCH] missing owner field entry on pppoe /proc

From: Stephen Hemminger <hidden>
Date: 2003-06-19 19:20:24

The /proc file operations for PPPOE is missing an owner entry.   This means that
if someone has /proc file open, it is still possible to unload the module.

Patch against 2.5.72 

diff -Nru a/drivers/net/pppoe.c b/drivers/net/pppoe.c
--- a/drivers/net/pppoe.c	Thu Jun 19 12:17:27 2003
+++ b/drivers/net/pppoe.c	Thu Jun 19 12:17:28 2003
@@ -1061,6 +1061,7 @@
 }
 
 static struct file_operations pppoe_seq_fops = {
+	.owner		= THIS_MODULE,
 	.open		= pppoe_seq_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,

Re: [PATCH] missing owner field entry on pppoe /proc

From: David S. Miller <hidden>
Date: 2003-06-19 19:36:25

   From: Stephen Hemminger [off-list ref]
   Date: Thu, 19 Jun 2003 12:20:24 -0700

   The /proc file operations for PPPOE is missing an owner entry.
   This means that if someone has /proc file open, it is still
   possible to unload the module.

Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help