Re: Flow cache flush oops

   If your compiler is producing anything like mine, then edi should be
   smp_processor_id() which looks a bit weird.  Please send me your
   net/core/flow.o file so that I can compare it.

   What compiler are you using? And how many CPUs?

The compiler version output is:
  gcc version 3.2 20020903 (Red Hat Linux 8.0 3.2-7)

The system has 4 CPUs.

Herbert, I'll send the flow.o file to you separately.

Thanks,
Tom

On Wed, Jun 18, 2003 at 06:10:48PM -0500, Tom Lendacky wrote:

The compiler version output is:
  gcc version 3.2 20020903 (Red Hat Linux 8.0 3.2-7)

Thanks, you've found two bugs in my code :) Firstly it's only initialising
one CPU so only that one has a flow cache.  Secondly flow_flush_cache is
not checking whether the calling CPU has been initialised.

I'll post a patch tonight.

Cheers,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

On Thu, Jun 19, 2003 at 10:07:04AM +1000, herbert wrote:

Thanks, you've found two bugs in my code :) Firstly it's only initialising
one CPU so only that one has a flow cache.  Secondly flow_flush_cache is
not checking whether the calling CPU has been initialised.

I'll post a patch tonight.

Here is the patch.

Cheers,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

   From: Herbert Xu [off-list ref]
   Date: Thu, 19 Jun 2003 19:35:18 +1000

   Here is the patch.

Applied, thanks Herbert.

Reviewing this made me notice that we don't check the
__get_free_pages() return value.  I'll fix that.

Thanks again.

On Thu, Jun 19, 2003 at 12:11:08PM -0700, David S. Miller wrote:

Reviewing this made me notice that we don't check the
__get_free_pages() return value.  I'll fix that.

Thanks.  Perhaps we should check that in the init function as well.

Cheers,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

   From: Herbert Xu [off-list ref]
   Date: Fri, 20 Jun 2003 08:43:08 +1000
   
   Perhaps we should check that in the init function as well.

Yep, I've applied your patch.

Thanks.