Re: [PATCH] Convert pppoe to new style protocol

On Tue, Jun 17, 2003 at 03:07:51PM -0700, David S. Miller wrote:

Please don't add new skb_linearize() users, I'm trying
to make that only local to net/core/dev.c

I know you find documentation unmanly, but maybe ...

- Werner

--- skbuff.h.orig	Wed Jun 18 09:13:57 2003
+++ skbuff.h	Wed Jun 18 09:15:05 2003

@@ -1126,6 +1126,9 @@
  *
  *	If there is no free memory -ENOMEM is returned, otherwise zero
  *	is returned and the old skb data released.
+ *
+ *	DO NOT USE THIS IN NEW CODE ! skb_linearize will be for internal
+ *	use by net/core/dev.c only.
  */
 int skb_linearize(struct sk_buff *skb, int gfp);
 

-- 
  _________________________________________________________________________
 / Werner Almesberger, Buenos Aires, Argentina         wa@almesberger.net /
/_http://www.almesberger.net/____________________________________________/

On Wed, Jun 18, 2003 at 09:21:26AM -0300, Werner Almesberger wrote:

On Tue, Jun 17, 2003 at 03:07:51PM -0700, David S. Miller wrote:

quoted

Please don't add new skb_linearize() users, I'm trying
to make that only local to net/core/dev.c

I know you find documentation unmanly, but maybe ...

But what is the replacement? For moving over whole subsystems to 
non linear skbs it's a bit late in the release...

And the "legacy protocol" setting cannot be used anymore because
it triggers a printk for every packet on a SMP kernel.

-Andi

   From: Andi Kleen [off-list ref]
   Date: 18 Jun 2003 14:51:59 +0200,Wed, 18 Jun 2003 14:51:59 +0200

   On Wed, Jun 18, 2003 at 09:21:26AM -0300, Werner Almesberger wrote:
   > I know you find documentation unmanly, but maybe ...
   
   But what is the replacement? For moving over whole subsystems to 
   non linear skbs it's a bit late in the release...
   
We did it for all of netfilter just the other week, networking
development still continues, it's not too late.

Stop looking for excuses and just do the work Andi.

   From: Werner Almesberger [off-list ref]
   Date: Wed, 18 Jun 2003 09:21:26 -0300

   + *
   + *	DO NOT USE THIS IN NEW CODE ! skb_linearize will be for internal
   + *	use by net/core/dev.c only.
     */
    int skb_linearize(struct sk_buff *skb, int gfp);

I have a better idea, I just added the __deprecated tag
to this function declaration :-)