Re: [PATCH] IPv6: Improvement of Source Address Selection

3 messages, 3 authors, 2002-09-28 · open the first message on its own page

Re: [PATCH] IPv6: Improvement of Source Address Selection

From: <hidden>
Date: 2002-09-28 02:23:47

Hello!
Otherwise I have no problems with the patch, Alexey?
I have... The implementation is bad. Source address must be retieved
from route, not running this elephant function each packet.

Alexey

Re: [PATCH] IPv6: Improvement of Source Address Selection

From: Andi Kleen <hidden>
Date: 2002-09-28 02:29:21

On Sat, Sep 28, 2002 at 06:28:29AM +0400, A.N.Kuznetsov wrote:
Hello!
quoted
Otherwise I have no problems with the patch, Alexey?
I have... The implementation is bad. Source address must be retieved
from route, not running this elephant function each packet.
So it just needs to be moved into ip_route_output, right ? 

-Andi

Re: [PATCH] IPv6: Improvement of Source Address Selection

From: David S. Miller <hidden>
Date: 2002-09-28 02:47:23

   From: kuznet@ms2.inr.ac.ru
   Date: Sat, 28 Sep 2002 06:28:29 +0400 (MSD)

   > Otherwise I have no problems with the patch, Alexey?
   
   I have... The implementation is bad. Source address must be retieved
   from route, not running this elephant function each packet.
   
This only runs at connect time, and when NULL fl->fl6_src is seen
by ip6_build_xmit() (this means RAW,UDP,ICMP which must make these
decisions anyways).

Is there really so much computation to be saved by moving this
to ipv6 route?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help