RE: [VLAN] VLAN patches

Bjorn
	Since the data type for the vlan_id is specified as an "unsigned short",
	The comparison (vlan_id < 0) will always be false due to the range of the data
 	type.

	-ds
	

-----Original Message-----
From: Andersson Björn [mailto:Bjorn.Andersson@ebc.ericsson.se] 
Sent: Monday, September 30, 2002 1:24 AM
To: netdev@oss.sgi.com
Subject: [VLAN] VLAN patches

Hi,
I hope you are the right receiver of 8021q-patches.
We are running SuSe 8.0, i.e kernel 2.4.18.

- When addding several egress-mappings we get stuck in an eternal
loop if they end up in the same hash-bucket, see vlan_dev.c.path.

- If we try to remove a vlan with VID 0, ifconfig stops working
completly.
We fixed it with vlan.c.patch.


-- 
* Björn Andersson                   bjorn.andersson@ebc.ericsson.se *
* Ericsson Enterprise AB            NA/EBC/BEES/DNCC                *
* Nacka Strand                      tel: +46-8-422 3512             *
* 13 189 Stockholm, Sweden          fax: +46-8-422 1010             *

Dave Santucci wrote:

Bjorn
	Since the data type for the vlan_id is specified as an "unsigned short",
	The comparison (vlan_id < 0) will always be false due to the range of the data
 	type.

	-ds
	

-----Original Message-----
From: Andersson Björn [mailto:Bjorn.Andersson@ebc.ericsson.se] 
Sent: Monday, September 30, 2002 1:24 AM
To: netdev@oss.sgi.com
Subject: [VLAN] VLAN patches

Hi,
I hope you are the right receiver of 8021q-patches.
We are running SuSe 8.0, i.e kernel 2.4.18.

- When addding several egress-mappings we get stuck in an eternal
loop if they end up in the same hash-bucket, see vlan_dev.c.path.

- If we try to remove a vlan with VID 0, ifconfig stops working
completly.
We fixed it with vlan.c.patch.

Is there any reason to ever let someone add a VLAN of ID 0 in the first place?

Ben

-- 
Ben Greear [off-list ref]       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear