kern-25-net-core-bug

--> jgarzik@mandrakesoft.com
--> pavel@atrey.karlin.mff.cuni.cz
--> netdev@oss.sgi.com

kernel-2.5.11  &  kernel-2.4.12 Bug-REPORT(net-core-dev)

Action: kernel-compilation from sources.

"make bzImage" stopped in error at:
net/core/dev.c: 1465 .. using return value of function declared void ...

I guessed (as errata):     ret=handle_diverter(skb);

& tried  (as corrige):     handle_diverter(skb);

it worked: bzImage did compile, but I'm not sure this was the correct 
solution.

System=Linux-Slakware-8.0 arch=i386 (CPU=athlon)
compile-tools: gcc-3.0.4,  glibc-2.2.5
GUI: KDE-3.0b2

END REPORT

Sender: [off-list ref]

--snip/snip

I guessed (as errata):     ret=handle_diverter(skb);

& tried  (as corrige):     handle_diverter(skb);

well, a cleaner thing would be to set ret=0 or ret=
... but on the other hand, the return value for netif_receive_skb
isn't checked (at least in process_backlog)

btw. is someone auditing the network code?
- like check all return values from functions which could fail.

	++dent

-- 
in some way i do, and in some way i don't.