[LTP] [RFC/PATCH] ltpstress.sh: added cmdline to set the block device

Subsystems: the rest

3 messages, 2 authors, 2014-09-19 · open the first message on its own page

[LTP] [RFC/PATCH] ltpstress.sh: added cmdline to set the block device

From: Stanislav Kholmanskikh <hidden>
Date: 2014-08-21 08:45:10

I think it's not needed to use set_block_device(),
create_block_device() from runltp, because their logic
is in tst_acquire_device()/tst_release_device() now.

Signed-off-by: Stanislav Kholmanskikh <redacted>
---
 testscripts/ltpstress.sh |   13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/testscripts/ltpstress.sh b/testscripts/ltpstress.sh
index a0dc088..39a5caf 100755
--- a/testscripts/ltpstress.sh
+++ b/testscripts/ltpstress.sh
@@ -58,7 +58,8 @@ usage()
 {
 
 	cat <<-END >&2
-	usage: ${0##*/} [ -d datafile ] [ -i # (in seconds) ] [ -I iofile ] [ -l logfile ] [ -m # (in Mb) ] [ -n ] [ -p ] [ -q ] [ -t duration ] [ -x TMPDIR ] [ [-S]|[-T] ]
+    usage: ${0##*/} [ -d datafile ] [ -i # (in seconds) ] [ -I iofile ] [ -l logfile ] [ -m # (in Mb) ]
+    [ -n ] [ -p ] [ -q ] [ -t duration ] [ -x TMPDIR ] [-b DEVICE] [-B LTP_DEV_FS_TYPE] [ [-S]|[-T] ]
 
     -d datafile     Data file for 'sar' or 'top' to log to. Default is "/tmp/ltpstress.data".
     -i # (in sec)   Interval that 'sar' or 'top' should take snapshots. Default is 10 seconds.
@@ -72,6 +73,10 @@ usage()
     -T              Use LTP's modified 'top' tool to measure data.
     -t duration     Execute the testsuite for given duration in hours. Default is 24.
     -x TMPDIR       Directory where temporary files will be created.
+    -b DEVICE       Some tests require an unmounted block device
+                    to run correctly. If DEVICE is not set, a loop device is
+                    created and used automatically.
+    -B LTP_DEV_FS_TYPE The file system of DEVICE.
 
 	example: ${0##*/} -d /tmp/sardata -l /tmp/ltplog.$$ -m 128 -t 24 -S
 	END
@@ -88,7 +93,7 @@ check_memsize()
   leftover_memsize=$memsize
 }
 
-while getopts d:hi:I:l:STt:m:npqx:\? arg
+while getopts d:hi:I:l:STt:m:npqx:b:B:\? arg
 do  case $arg in
 
 	d)	datafile="$OPTARG";;
@@ -138,6 +143,10 @@ do  case $arg in
 
 	x)	export TMPBASE=$(readlink -f ${OPTARG});;
 
+	b)	export LTP_DEV=${OPTARG};;
+
+	B)	export LTP_DEV_FS_TYPE=${OPTARG};;
+
         \?)     echo "Help info:"
 		usage;;
         esac
-- 
1.7.1


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC/PATCH] ltpstress.sh: added cmdline to set the block device

From: Stanislav Kholmanskikh <hidden>
Date: 2014-09-15 12:26:55

Hi!

Could anybody help to review this change, please?

Thanks.

On 21.08.2014 12:44, Stanislav Kholmanskikh wrote:
quoted hunk
I think it's not needed to use set_block_device(),
create_block_device() from runltp, because their logic
is in tst_acquire_device()/tst_release_device() now.

Signed-off-by: Stanislav Kholmanskikh <redacted>
---
  testscripts/ltpstress.sh |   13 +++++++++++--
  1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/testscripts/ltpstress.sh b/testscripts/ltpstress.sh
index a0dc088..39a5caf 100755
--- a/testscripts/ltpstress.sh
+++ b/testscripts/ltpstress.sh
@@ -58,7 +58,8 @@ usage()
  {

  	cat <<-END >&2
-	usage: ${0##*/} [ -d datafile ] [ -i # (in seconds) ] [ -I iofile ] [ -l logfile ] [ -m # (in Mb) ] [ -n ] [ -p ] [ -q ] [ -t duration ] [ -x TMPDIR ] [ [-S]|[-T] ]
+    usage: ${0##*/} [ -d datafile ] [ -i # (in seconds) ] [ -I iofile ] [ -l logfile ] [ -m # (in Mb) ]
+    [ -n ] [ -p ] [ -q ] [ -t duration ] [ -x TMPDIR ] [-b DEVICE] [-B LTP_DEV_FS_TYPE] [ [-S]|[-T] ]

      -d datafile     Data file for 'sar' or 'top' to log to. Default is "/tmp/ltpstress.data".
      -i # (in sec)   Interval that 'sar' or 'top' should take snapshots. Default is 10 seconds.
@@ -72,6 +73,10 @@ usage()
      -T              Use LTP's modified 'top' tool to measure data.
      -t duration     Execute the testsuite for given duration in hours. Default is 24.
      -x TMPDIR       Directory where temporary files will be created.
+    -b DEVICE       Some tests require an unmounted block device
+                    to run correctly. If DEVICE is not set, a loop device is
+                    created and used automatically.
+    -B LTP_DEV_FS_TYPE The file system of DEVICE.

  	example: ${0##*/} -d /tmp/sardata -l /tmp/ltplog.$$ -m 128 -t 24 -S
  	END
@@ -88,7 +93,7 @@ check_memsize()
    leftover_memsize=$memsize
  }

-while getopts d:hi:I:l:STt:m:npqx:\? arg
+while getopts d:hi:I:l:STt:m:npqx:b:B:\? arg
  do  case $arg in

  	d)	datafile="$OPTARG";;
@@ -138,6 +143,10 @@ do  case $arg in

  	x)	export TMPBASE=$(readlink -f ${OPTARG});;

+	b)	export LTP_DEV=${OPTARG};;
+
+	B)	export LTP_DEV_FS_TYPE=${OPTARG};;
+
          \?)     echo "Help info:"
  		usage;;
          esac
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC/PATCH] ltpstress.sh: added cmdline to set the block device

From: chrubis@suse.cz
Date: 2014-09-19 13:20:25

Hi!
Could anybody help to review this change, please?
Sorry, I've read the email but forgot to reply the last time.

Looks good, acked.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Slashdot TV.  Video for Nerds.  Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help