Inter-revision diff: patch 11

Comparing v2 (message) to v3 (message)

--- v2
+++ v3
@@ -1,62 +1,106 @@
-Some panel/encoder/connector driver includes omap-panel-data.h but they
-do not need it. Remove the inclusion of video/omap-panel-data.h from these
-drivers.
+The panel is not used by any legacy board files so the legacy (pdata) boot
+support can be dropped.
 
 Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
 ---
- drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c           | 1 -
- drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c        | 1 -
- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c             | 1 -
- drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c | 1 -
- 4 files changed, 4 deletions(-)
+ .../fbdev/omap2/omapfb/displays/connector-hdmi.c   | 42 ++++------------------
+ include/video/omap-panel-data.h                    | 10 ------
+ 2 files changed, 6 insertions(+), 46 deletions(-)
 
-diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
-index 2fd5602880a7..6b7d4fc3ac12 100644
---- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
-+++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
-@@ -16,7 +16,6 @@
- #include <linux/of_gpio.h>
+diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c
+index 6ee4129bc0c0..231b8588a59f 100644
+--- a/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c
++++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c
+@@ -18,7 +18,6 @@
+ #include <drm/drm_edid.h>
  
  #include <video/omapdss.h>
 -#include <video/omap-panel-data.h>
  
- struct panel_drv_data {
- 	struct omap_dss_device dssdev;
-diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
-index 916a89978387..f4f23f5cfe3e 100644
---- a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
-+++ b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
-@@ -17,7 +17,6 @@
- #include <linux/gpio/consumer.h>
+ static const struct omap_video_timings hdmic_default_timings = {
+ 	.x_res		= 640,
+@@ -206,30 +205,6 @@ static struct omap_dss_driver hdmic_driver = {
+ 	.set_hdmi_infoframe	= hdmic_set_infoframe,
+ };
  
- #include <video/omapdss.h>
--#include <video/omap-panel-data.h>
+-static int hdmic_probe_pdata(struct platform_device *pdev)
+-{
+-	struct panel_drv_data *ddata = platform_get_drvdata(pdev);
+-	struct connector_hdmi_platform_data *pdata;
+-	struct omap_dss_device *in, *dssdev;
+-
+-	pdata = dev_get_platdata(&pdev->dev);
+-
+-	ddata->hpd_gpio = -ENODEV;
+-
+-	in = omap_dss_find_output(pdata->source);
+-	if (in == NULL) {
+-		dev_err(&pdev->dev, "Failed to find video source\n");
+-		return -EPROBE_DEFER;
+-	}
+-
+-	ddata->in = in;
+-
+-	dssdev = &ddata->dssdev;
+-	dssdev->name = pdata->name;
+-
+-	return 0;
+-}
+-
+ static int hdmic_probe_of(struct platform_device *pdev)
+ {
+ 	struct panel_drv_data *ddata = platform_get_drvdata(pdev);
+@@ -261,6 +236,9 @@ static int hdmic_probe(struct platform_device *pdev)
+ 	struct omap_dss_device *dssdev;
+ 	int r;
  
- struct panel_drv_data {
- 	struct omap_dss_device dssdev;
-diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
-index 36485c2137ce..6dcb75f6f0c5 100644
---- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
-+++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
-@@ -26,7 +26,6 @@
- #include <linux/of_gpio.h>
++	if (!pdev->dev.of_node)
++		return -ENODEV;
++
+ 	ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL);
+ 	if (!ddata)
+ 		return -ENOMEM;
+@@ -268,17 +246,9 @@ static int hdmic_probe(struct platform_device *pdev)
+ 	platform_set_drvdata(pdev, ddata);
+ 	ddata->dev = &pdev->dev;
  
- #include <video/omapdss.h>
--#include <video/omap-panel-data.h>
- #include <video/mipi_display.h>
+-	if (dev_get_platdata(&pdev->dev)) {
+-		r = hdmic_probe_pdata(pdev);
+-		if (r)
+-			return r;
+-	} else if (pdev->dev.of_node) {
+-		r = hdmic_probe_of(pdev);
+-		if (r)
+-			return r;
+-	} else {
+-		return -ENODEV;
+-	}
++	r = hdmic_probe_of(pdev);
++	if (r)
++		return r;
  
- /* DSI Virtual channel. Hardcoded for now. */
-diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
-index 458f77bc473d..1bd682864217 100644
---- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
-+++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
-@@ -17,7 +17,6 @@
- #include <linux/gpio.h>
+ 	if (gpio_is_valid(ddata->hpd_gpio)) {
+ 		r = devm_gpio_request_one(&pdev->dev, ddata->hpd_gpio,
+diff --git a/include/video/omap-panel-data.h b/include/video/omap-panel-data.h
+index e7b0e889d6d0..c0836b118f67 100644
+--- a/include/video/omap-panel-data.h
++++ b/include/video/omap-panel-data.h
+@@ -59,16 +59,6 @@ struct connector_dvi_platform_data {
+ };
  
- #include <video/omapdss.h>
--#include <video/omap-panel-data.h>
- 
- static struct omap_video_timings lb035q02_timings = {
- 	.x_res = 320,
+ /**
+- * connector_hdmi platform data
+- * @name: name for this display entity
+- * @source: name of the display entity used as a video source
+- */
+-struct connector_hdmi_platform_data {
+-	const char *name;
+-	const char *source;
+-};
+-
+-/**
+  * connector_atv platform data
+  * @name: name for this display entity
+  * @source: name of the display entity used as a video source
 -- 
 2.8.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help