Inter-revision diff: cover letter

Comparing v2 (message) to v6 (message)

--- v2
+++ v6
@@ -1,12 +1,50 @@
-Goal of this patch series is to make the mc13892 PWRON1 button usable,
-found e.g. on amazon kindle D01100/D01200 readers.
+Goal of this patch series is to make mx13xxx power buttons usable
+on DT based systems.
 A ten-year-old IRQ issue needed a fix, mc13783-pwrbutton had to be
-extended to the other to mc13xxx PMIC as well (keeping the mc13892
-PWRON3 key unsupported for simplicity) and adding OF support.
-The implementation has been tested on amazon kindle D01100 and D01200
-readers using PWRON1 of a mc13892.
+extended to the other to mc13xxx PMIC as well and adding OF support.
+The implementation has been tested with PWRON1 on mc13892 found e.g.
+in amazon kindle D01100/D01200/EY21 readers and also in on mc34708
+in the imx53-qsrb "i.MX53 Quick start board".
 
-V2:
+Changes in v6:
+- Link to v5: https://lore.kernel.org/linux-input/20251008064401.13863-1-akurz@blala.de/
+- Rebase to v6.18-rc1
+- Add a imx53-qsrb dts patch to enable the "power" button on the
+  i.MX53 Quick start board.
+
+Changes in v5:
+- Link to v4: https://lore.kernel.org/linux-input/20250914193723.10544-1-akurz@blala.de/
+- Rebase to current to include already merged dt-schema patches and
+  a different mc13xxx related patch.
+- Drop patch to use devm_mfd_add_devices and devm_regmap_add_irq_chip -
+  won't like to do the proposed mutex-cleanup now.
+- While adding OF support, remove the platform_data configuration
+  interface as proposed by Dmitry Torokhov. Also drop the change
+  to use module_platform_driver_probe.
+
+Changes in v4:
+- Link to v3: https://lore.kernel.org/linux-input/20250829201517.15374-1-akurz@blala.de/
+- Rebase to git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
+  tags/ib-mfd-input-rtc-v6.18 in order to include a different mc13xxx
+  related patch (sorry for that).
+- Re-ordered commits since dt-bindings changes already go reviewes by
+  Rob Herring.
+- Following Dmitrys suggestions, resources for irq are now passed from
+  mfd to input allowing a more simple implementation. Work on other mfd
+  cells with irq usage might still be a future project.
+- Input-related differences between the mc13xxx variants are encoded
+  in data structures, making the implementation of mc13892 PWRON3 a
+  simple task.
+
+Changes in v3:
+- Link to v2: https://lore.kernel.org/linux-input/20250823144441.12654-1-akurz@blala.de/
+- Undo all changes to led-control (rename to fsl,led-control), thanks Rob
+- Restructured the new buttons node for unevaluatedProperties: false
+- Various other remarks from Rob
+- Rebase to current state
+
+Changes in v2:
+- Link to v1: https://lore.kernel.org/linux-input/20250817102751.29709-1-akurz@blala.de/
 - Convert dt-bindings from txt to fsl,mc13xxx.yaml and add vendor prefix
   to led-control property, causing changes in dts and driver.
 - Change node name from pwrbuttons to buttons
@@ -18,34 +56,23 @@
 - Provide chip-specific max button id via platform_device_id, therefore
   swap patches 3 and 4.
 
-Thanks in advance for the review effords,
-Cheers, Alexnder
-
-Alexander Kurz (9):
-  Input: mc13783-pwrbutton: fix irq mixup
+Alexander Kurz (6):
   Input: mc13783-pwrbutton: use managed resources
+  Input: mc13783-pwrbutton: fix irq mixup and use resources
   Input: mc13783-pwrbutton: convert pdata members to array
   Input: mc13783-pwrbutton: enable other mc13xxx PMIC
-  dt-bindings: mfd: fsl,mc13xxx: convert txt to DT schema
-  dt-bindings: mfd: fsl,mc13xxx: add buttons node
-  ARM: dts: imx: Use fsl,led-control as mc13xxx node name
-  leds: mc13783: use fsl,led-control as node name
-  Input: mc13783-pwrbutton: add OF support
+  Input: mc13783-pwrbutton: add OF support and drop platform_data
+  ARM: dts: imx53: add imx53-qsrb PMIC power button
 
- .../devicetree/bindings/mfd/fsl,mc13xxx.yaml  | 272 ++++++++++++++++++
- .../devicetree/bindings/mfd/mc13xxx.txt       | 156 ----------
- .../dts/nxp/imx/imx27-phytec-phycore-som.dtsi |   2 +-
- arch/arm/boot/dts/nxp/imx/imx51-zii-rdu1.dts  |   2 +-
- .../boot/dts/nxp/imx/imx51-zii-scu2-mezz.dts  |   2 +-
- .../boot/dts/nxp/imx/imx51-zii-scu3-esb.dts   |   2 +-
- drivers/input/misc/Kconfig                    |   4 +-
- drivers/input/misc/mc13783-pwrbutton.c        | 235 +++++++++++----
- drivers/leds/leds-mc13783.c                   |   2 +-
- include/linux/mfd/mc13783.h                   |   4 +-
- include/linux/mfd/mc13xxx.h                   |  10 +-
- 11 files changed, 461 insertions(+), 230 deletions(-)
- create mode 100644 Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
- delete mode 100644 Documentation/devicetree/bindings/mfd/mc13xxx.txt
+ arch/arm/boot/dts/nxp/imx/imx53-qsrb.dts |  12 +
+ drivers/input/misc/Kconfig               |   4 +-
+ drivers/input/misc/mc13783-pwrbutton.c   | 278 +++++++++++++----------
+ drivers/mfd/mc13xxx-core.c               |  49 +++-
+ drivers/mfd/mc13xxx.h                    |   2 +
+ include/linux/mfd/mc13783.h              |   4 +-
+ include/linux/mfd/mc13892.h              |   1 +
+ include/linux/mfd/mc13xxx.h              |  20 +-
+ 8 files changed, 219 insertions(+), 151 deletions(-)
 
 -- 
 2.39.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help