Reviews by ncardwell@google.com · lkml

All review-attestation trailers (Reviewed-by / Acked-by / Tested-by / Reported-by / Suggested-by / Co-developed-by / Reported-and-tested-by) by this address on the lkml archive.

100 attestations · capped at 100 most-recent. (57 Acked-by, 8 Co-developed-by, 1 Reported-by, 18 Reviewed-by, 5 Suggested-by, 11 Tested-by)

• COLD30d REVIEWED: 1 (1M) Re: [PATCH net] tcp: fix icsk_ack.ato bitfield overflow
  2026-08-07 · Reviewed-by
• STALE315d REVIEWED: 1 (1M) Re: [PATCH net v3 4/4] tcp: fix too slow tcp_rcvbuf_grow() action
  2025-10-29 · Reviewed-by
• STALE315d REVIEWED: 1 (1M) Re: [PATCH net v3 3/4] tcp: add newval parameter to tcp_rcvbuf_grow()
  2025-10-29 · Reviewed-by
• STALE315d REVIEWED: 1 (1M) Re: [PATCH net v3 2/4] trace: tcp: add three metrics to trace_tcp_rcvbuf_grow()
  2025-10-29 · Reviewed-by
• STALE315d [PATCH net v3 4/4] tcp: fix too slow tcp_rcvbuf_grow() action
  2025-10-28 · Reported-by
• STALE384d REVIEWED: 3 (2M) [PATCH AUTOSEL 6.14 313/642] tcp: be less liberal in TSEcr received while in SYN_RECV state
  2025-05-05 · Reviewed-by
• STALE541d REVIEWED: 1 (1M) [PATCH v2 stable 5.15 1/2] tcp: fix races in tcp_abort()
  2025-03-17 · Acked-by
• STALE541d REVIEWED: 1 (1M) [PATCH v2 stable 6.1 1/2] tcp: fix races in tcp_abort()
  2025-03-17 · Acked-by
• STALE542d REVIEWED: 1 (1M) [PATCH 1/2] tcp: fix races in tcp_abort()
  2025-03-14 · Acked-by
• STALE698d REVIEWED: 1 (1M) Re: [PATCH net v3] tcp: check skb is non-NULL in tcp_rto_delta_us()
  2024-09-10 · Acked-by
• STALE1059d REVIEWED: 1 (1M) Re: [PATCH net-next,v3] tcp: Set pingpong threshold via sysctl
  2023-10-16 · Acked-by
• STALE1454d REVIEWED: 1 (1M) [PATCH 4.19 17/79] tcp: annotate data-race around challenge_timestamp
  2022-09-13 · Acked-by
• STALE1454d REVIEWED: 1 (1M) [PATCH 5.4 018/108] tcp: annotate data-race around challenge_timestamp
  2022-09-13 · Acked-by
• STALE1463d REVIEWED: 1 (1M) [PATCH 5.19 049/155] tcp: annotate data-race around challenge_timestamp
  2022-09-06 · Acked-by
• STALE1454d REVIEWED: 1 (1M) [PATCH 5.15 027/107] tcp: annotate data-race around challenge_timestamp
  2022-09-06 · Acked-by
• STALE1463d REVIEWED: 1 (1M) [PATCH 5.10 18/80] tcp: annotate data-race around challenge_timestamp
  2022-09-06 · Acked-by
• STALE1499d REVIEWED: 5 (5M) [PATCH 5.18 32/88] Revert "tcp: change pingpong threshold to 3"
  2022-08-01 · Suggested-by
• STALE1499d REVIEWED: 5 (5M) [PATCH 5.18 32/88] Revert "tcp: change pingpong threshold to 3"
  2022-08-01 · Acked-by
• STALE1499d REVIEWED: 5 (5M) [PATCH 5.15 23/69] Revert "tcp: change pingpong threshold to 3"
  2022-08-01 · Suggested-by
• STALE1499d REVIEWED: 5 (5M) [PATCH 5.15 23/69] Revert "tcp: change pingpong threshold to 3"
  2022-08-01 · Acked-by
• STALE1499d REVIEWED: 5 (5M) [PATCH 5.10 17/65] Revert "tcp: change pingpong threshold to 3"
  2022-08-01 · Suggested-by
• STALE1499d REVIEWED: 5 (5M) [PATCH 5.10 17/65] Revert "tcp: change pingpong threshold to 3"
  2022-08-01 · Acked-by
• STALE1113d REVIEWED: 1 (1M) [PATCH 5.17 115/298] tcp: tcp_rtx_synack() can be called from process context
  2022-06-13 · Acked-by
• STALE1549d REVIEWED: 1 (1M) [PATCH 5.18 131/339] tcp: tcp_rtx_synack() can be called from process context
  2022-06-13 · Acked-by
• STALE1548d REVIEWED: 1 (1M) [PATCH 5.15 099/247] tcp: tcp_rtx_synack() can be called from process context
  2022-06-13 · Acked-by
• STALE1549d REVIEWED: 1 (1M) [PATCH 5.10 068/172] tcp: tcp_rtx_synack() can be called from process context
  2022-06-13 · Acked-by
• STALE1549d REVIEWED: 1 (1M) [PATCH 4.19 223/287] tcp: tcp_rtx_synack() can be called from process context
  2022-06-13 · Acked-by
• STALE1548d REVIEWED: 1 (1M) [PATCH 5.4 333/411] tcp: tcp_rtx_synack() can be called from process context
  2022-06-13 · Acked-by
• STALE1549d REVIEWED: 1 (1M) [PATCH 4.14 163/218] tcp: tcp_rtx_synack() can be called from process context
  2022-06-13 · Acked-by
• STALE1549d REVIEWED: 1 (1M) [PATCH 4.9 126/167] tcp: tcp_rtx_synack() can be called from process context
  2022-06-13 · Acked-by
• STALE1585d REVIEWED: 6 (6M) [PATCH 5.17 155/225] tcp: fix F-RTO may not work correctly when receiving DSACK
  2022-05-04 · Acked-by
• STALE1585d REVIEWED: 6 (6M) [PATCH 5.17 155/225] tcp: fix F-RTO may not work correctly when receiving DSACK
  2022-05-04 · Tested-by
• STALE1585d REVIEWED: 6 (6M) [PATCH 5.17 107/225] tcp: ensure to use the most recently sent skb when filling the rate sample
  2022-05-04 · Acked-by
• STALE1585d REVIEWED: 6 (6M) [PATCH 5.17 107/225] tcp: ensure to use the most recently sent skb when filling the rate sample
  2022-05-04 · Tested-by
• STALE1584d REVIEWED: 6 (6M) [PATCH 5.15 126/177] tcp: fix F-RTO may not work correctly when receiving DSACK
  2022-05-04 · Acked-by
• STALE1584d REVIEWED: 6 (6M) [PATCH 5.15 126/177] tcp: fix F-RTO may not work correctly when receiving DSACK
  2022-05-04 · Tested-by
• STALE1584d REVIEWED: 6 (6M) [PATCH 5.15 086/177] tcp: ensure to use the most recently sent skb when filling the rate sample
  2022-05-04 · Acked-by
• STALE1584d REVIEWED: 6 (6M) [PATCH 5.15 086/177] tcp: ensure to use the most recently sent skb when filling the rate sample
  2022-05-04 · Tested-by
• STALE1588d REVIEWED: 6 (6M) [PATCH 5.10 069/129] tcp: ensure to use the most recently sent skb when filling the rate sample
  2022-05-04 · Acked-by
• STALE1588d REVIEWED: 6 (6M) [PATCH 5.10 069/129] tcp: ensure to use the most recently sent skb when filling the rate sample
  2022-05-04 · Tested-by
• STALE1588d REVIEWED: 6 (6M) [PATCH 5.10 098/129] tcp: fix F-RTO may not work correctly when receiving DSACK
  2022-05-04 · Acked-by
• STALE1588d REVIEWED: 6 (6M) [PATCH 5.10 098/129] tcp: fix F-RTO may not work correctly when receiving DSACK
  2022-05-04 · Tested-by
• STALE1588d REVIEWED: 6 (6M) [PATCH 5.4 67/84] tcp: fix F-RTO may not work correctly when receiving DSACK
  2022-05-04 · Acked-by
• STALE1588d REVIEWED: 6 (6M) [PATCH 5.4 67/84] tcp: fix F-RTO may not work correctly when receiving DSACK
  2022-05-04 · Tested-by
• STALE1588d REVIEWED: 6 (6M) [PATCH 5.4 49/84] tcp: ensure to use the most recently sent skb when filling the rate sample
  2022-05-04 · Acked-by
• STALE1588d REVIEWED: 6 (6M) [PATCH 5.4 49/84] tcp: ensure to use the most recently sent skb when filling the rate sample
  2022-05-04 · Tested-by
• STALE1737d [PATCH 4.14 026/106] tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
  2021-12-06 · Co-developed-by
• STALE1737d [PATCH 4.9 21/62] tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
  2021-12-06 · Co-developed-by
• STALE1737d [PATCH 4.4 17/52] tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
  2021-12-06 · Co-developed-by
• STALE1744d [PATCH 5.10 083/121] tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
  2021-11-29 · Co-developed-by
• STALE1744d [PATCH 4.19 51/69] tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
  2021-11-29 · Co-developed-by
• STALE1744d [PATCH 5.4 67/92] tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
  2021-11-29 · Co-developed-by
• STALE1744d [PATCH 5.15 133/179] tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
  2021-11-29 · Co-developed-by
• STALE1502d REVIEWED: 1 (1M) [PATCH 5.10 324/575] tcp: switch orphan_count to bare per-cpu counters
  2021-11-16 · Acked-by
• STALE1758d REVIEWED: 1 (1M) [PATCH 5.14 432/849] tcp: switch orphan_count to bare per-cpu counters
  2021-11-16 · Acked-by
• STALE1750d REVIEWED: 1 (1M) [PATCH 5.15 433/917] tcp: switch orphan_count to bare per-cpu counters
  2021-11-16 · Acked-by
• STALE1801d REVIEWED: 2 (1M) [PATCH 4.19 51/95] tcp: always set retrans_stamp on recovery
  2021-10-04 · Reviewed-by
• STALE1801d REVIEWED: 2 (1M) [PATCH 4.19 52/95] tcp: create a helper to model exponential backoff
  2021-10-04 · Reviewed-by
• STALE1808d REVIEWED: 2 (1M) [PATCH stable 4.19 2/4] tcp: always set retrans_stamp on recovery
  2021-09-26 · Reviewed-by
• STALE1808d REVIEWED: 2 (1M) [PATCH stable 4.19 3/4] tcp: create a helper to model exponential backoff
  2021-09-26 · Reviewed-by
• STALE1814d REVIEWED: 6 (5M) [PATCH 5.14 064/168] tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()
  2021-09-20 · Acked-by
• STALE1813d REVIEWED: 6 (5M) [PATCH 5.10 042/122] tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()
  2021-09-20 · Acked-by
• STALE1814d REVIEWED: 6 (5M) [PATCH 5.4 223/260] tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()
  2021-09-20 · Acked-by
• STALE1814d REVIEWED: 2 (1M) [PATCH 5.4 140/260] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-20 · Acked-by
• STALE1814d REVIEWED: 6 (5M) [PATCH 4.19 269/293] tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()
  2021-09-20 · Acked-by
• STALE1814d REVIEWED: 2 (1M) [PATCH 4.19 220/293] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-20 · Acked-by
• STALE1814d REVIEWED: 6 (5M) [PATCH 4.14 203/217] tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()
  2021-09-20 · Acked-by
• STALE1814d REVIEWED: 6 (5M) [PATCH 4.9 163/175] tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()
  2021-09-20 · Acked-by
• STALE1818d REVIEWED: 2 (1M) [PATCH 5.14 312/432] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-16 · Acked-by
• STALE1804d REVIEWED: 2 (1M) [PATCH 5.13 278/380] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-16 · Acked-by
• STALE1816d REVIEWED: 2 (1M) [PATCH 5.10 224/306] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-16 · Acked-by
• STALE1826d REVIEWED: 2 (1M) [PATCH AUTOSEL 4.19 51/74] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-09 · Acked-by
• STALE1826d REVIEWED: 2 (1M) [PATCH AUTOSEL 5.4 073/109] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-09 · Acked-by
• STALE1826d REVIEWED: 2 (1M) [PATCH AUTOSEL 5.10 119/176] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-09 · Acked-by
• STALE1824d REVIEWED: 2 (1M) [PATCH AUTOSEL 5.13 146/219] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-09 · Acked-by
• STALE1821d REVIEWED: 2 (1M) [PATCH AUTOSEL 5.14 165/252] tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
  2021-09-09 · Acked-by
• STALE1863d REVIEWED: 3 (1M) [PATCH 5.13 134/223] tcp: disable TFO blackhole logic by default
  2021-07-26 · Acked-by
• STALE1682d REVIEWED: 3 (1M) [PATCH 5.10 099/167] tcp: disable TFO blackhole logic by default
  2021-07-26 · Acked-by
• STALE1874d REVIEWED: 2 (2M) [PATCH 5.13 145/156] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized
  2021-07-22 · Acked-by
• STALE1874d REVIEWED: 2 (2M) [PATCH 5.13 145/156] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized
  2021-07-22 · Tested-by
• STALE1874d REVIEWED: 2 (2M) [PATCH 5.10 117/125] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized
  2021-07-22 · Acked-by
• STALE1874d REVIEWED: 2 (2M) [PATCH 5.10 117/125] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized
  2021-07-22 · Tested-by
• DORMANTno replies REVIEWED: 2 (2M) Re: [PATCH v6] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized
  2021-07-06 · Acked-by
• DORMANTno replies REVIEWED: 2 (2M) Re: [PATCH v6] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized
  2021-07-06 · Tested-by
• STALE1924d [RFCv2 1/3] tcp: Use smaller mtu probes if RACK is enabled
  2021-05-26 · Suggested-by
• STALE1941d [RFC 2/3] tcp: Use mtu probes if RACK is enabled
  2021-05-11 · Suggested-by
• STALE2001d REVIEWED: 5 (5M) [PATCH 4.19 020/120] net/mlx4_en: update moderation when config reset
  2021-03-15 · Reviewed-by
• STALE2001d REVIEWED: 5 (5M) [PATCH 4.14 16/95] net/mlx4_en: update moderation when config reset
  2021-03-15 · Reviewed-by
• STALE1739d REVIEWED: 5 (5M) [PATCH 5.10 045/290] net/mlx4_en: update moderation when config reset
  2021-03-15 · Reviewed-by
• STALE2001d REVIEWED: 5 (5M) [PATCH 5.11 056/306] net/mlx4_en: update moderation when config reset
  2021-03-15 · Reviewed-by
• STALE2003d REVIEWED: 5 (5M) [PATCH 5.4 027/168] net/mlx4_en: update moderation when config reset
  2021-03-15 · Reviewed-by
• STALE1991d REVIEWED: 5 (5M) [PATCH 4.9 12/78] net/mlx4_en: update moderation when config reset
  2021-03-15 · Reviewed-by
• STALE2003d REVIEWED: 5 (5M) [PATCH 4.4 14/75] net/mlx4_en: update moderation when config reset
  2021-03-15 · Reviewed-by
• STALE2040d REVIEWED: 1 (1M) [PATCH 5.4 08/32] tcp: make TCP_USER_TIMEOUT accurate for zero window probes
  2021-02-05 · Reviewed-by
• STALE2044d REVIEWED: 1 (1M) [PATCH 5.10 141/142] tcp: make TCP_USER_TIMEOUT accurate for zero window probes
  2021-02-02 · Reviewed-by
• STALE2044d REVIEWED: 2 (1M) [PATCH 4.14 30/30] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN
  2021-02-02 · Acked-by
• STALE2044d REVIEWED: 2 (1M) [PATCH 4.19 37/37] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN
  2021-02-02 · Acked-by
• STALE2044d REVIEWED: 2 (1M) [PATCH 5.4 61/61] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN
  2021-02-02 · Acked-by
• STALE2044d REVIEWED: 2 (1M) [PATCH 5.10 142/142] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN
  2021-02-02 · Acked-by
• STALE2052d REVIEWED: 5 (4M) [PATCH 5.4 86/86] tcp: fix TCP_USER_TIMEOUT with zero window
  2021-01-26 · Co-developed-by