Thread (179 messages) 179 messages, 28 authors, 2022-05-24

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Date: 2022-05-17 16:46:55
Also in: kexec, linux-alpha, linux-edac, linux-hyperv, linux-leds, linux-mips, linux-pm, linux-remoteproc, linux-s390, linux-tegra, linux-um, linuxppc-dev, netdev, rcu, sparclinux, xen-devel

On 17/05/2022 11:11, Petr Mladek wrote:
[...]
quoted
quoted
Then notifiers could make an informed choice on whether to deep dive to
get all the possible details (when there is no kdump) or just skim the high
level stuff (to maximize chance of getting a successful kdump).

-Tony
Good idea Tony! What if I wire a kexec_crash_loaded() in the notifier?
I like this idea.

One small problem is that kexec_crash_loaded() has valid result
only under kexec_mutex. On the other hand, it should stay true
once loaded so that the small race window should be innocent.
quoted
With that, are you/Petr/Dinh OK in moving it for the info list?
Sounds good to me.

Best Regards,
Petr
Perfect, I'll do that for V2 then =)

Tony / Dinh - can I just *skip* this notifier *if kdump* is set or else
we run the code as-is? Does that make sense to you?

I'll postpone it to run almost in the end of info list (last position is
for panic_print).

Thanks,


Guilherme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help