Re: [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset()
From: Jiri Kosina <jikos@kernel.org>
Date: 2021-10-27 08:15:09
Also in:
linux-input
Possibly related (same subject, not in this thread)
- 2021-10-18 · Re: [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset() · Jiri Kosina <jikos@kernel.org>
- 2021-10-18 · Re: [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset() · Dmitry Torokhov <dmitry.torokhov@gmail.com>
- 2021-10-17 · Re: [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset() · Ping Cheng <hidden>
- 2021-10-15 · Re: [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset() · Cai Huoqing <hidden>
- 2021-10-07 · Re: [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset() · Jiri Kosina <jikos@kernel.org>
On Tue, 26 Oct 2021, Jason Gerecke wrote:
Following up on this. I took a second look at the shared struct, and believe that things should work fine during initialization and steady-state. There are, however, opportunities for e.g. one device/thread to be removed and set e.g. `shared->touch = NULL` while a second device/thread is attempting to send an event out of that device. This is going to be very rare and only on disconnect, which is probably why we've never received reports of real-world issues. This shared issue is present with or without the changes by Cai and myself. I would ask that these two patches be merged
Now applied. Thanks, -- Jiri Kosina SUSE Labs