On Fri, May 7, 2021 at 2:16 PM Greg Kroah-Hartman
[off-list ref] wrote:

On Fri, May 07, 2021 at 01:12:18PM +0100, Matthew Wilcox wrote:

quoted

On Fri, May 07, 2021 at 02:03:04PM +0200, Greg Kroah-Hartman wrote:

quoted

On Fri, May 07, 2021 at 01:41:50PM +0200, Ondrej Mosnacek wrote:

quoted

Make sure that security_locked_down() is checked last so that a bogus
denial is not reported by SELinux when (ia->ia_valid & (ATTR_MODE |
ATTR_UID | ATTR_GID)) is zero.

Why would this be "bogus"?

I presume selinux is logging a denial ... but we don't then actually
deny the operation.

That would be nice to note here...

Granted, I didn't do a good job of describing the issue in the patch
description... I'll send a v2 with hopefully a better description.

-- 
Ondrej Mosnacek
Software Engineer, Linux Security - SELinux kernel
Red Hat, Inc.