Re: [PATCH 0/4] Stylus-on-touchscreen device support
From: наб <hidden>
Date: 2021-03-08 10:41:15
Also in:
linux-input
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: наб <hidden>
Date: 2021-03-08 10:41:15
Also in:
linux-input
On Mon, Mar 08, 2021 at 11:21:56AM +0100, Benjamin Tissoires wrote:
On Mon, Mar 8, 2021 at 11:15 AM Jiri Kosina [off-list ref] wrote:quoted
On Wed, 17 Feb 2021, наб wrote:quoted
This patchset adds support for stylus-on-touchscreen devices as found on the OneMix 3 Pro and Dell Inspiron 15 7000 2-in-1 (7591), among others; with it, they properly behave like a drawing tablet. Patches 2 and 4 funxionally depend on patch 1. Patch 4 needs patch 3 to apply. The output of this patchset and the need for a kernel, rather than userspace, patch was previously discussed here: https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/558#note_792834 Ahelenia Ziemiańska (4): HID: multitouch: require Finger field to mark Win8 reports as MT HID: multitouch: set Stylus suffix for Stylus-application devices, too HID: input: replace outdated HID numbers+comments with macros HID: input: work around Win8 stylus-on-touchscreen reporting drivers/hid/hid-input.c | 47 +++++++++++++++++++++++++++++++++--- drivers/hid/hid-multitouch.c | 18 ++++++++------ 2 files changed, 55 insertions(+), 10 deletions(-)Benjamin, this patchset looks good to me; do you have any objections on queuing it for 5.13?Please hold on this one. I am pretty sure this should break the test suite but couldn't have the chance to get to it. Will pop this one up in TODO list.
This also has minor behavioural problems regarding BTN_STYLUS reporting that came out in testing, and I didn't have the time to dig through and verify the logs from pre-v2 a tester sent back last week. I hope to send v2 today/tomorrow, energy and time permitting. Best, наб