Thread (11 messages) 11 messages, 3 authors, 2021-01-20

Re: [PATCH 4/5] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'

From: Benjamin Tissoires <hidden>
Date: 2021-01-14 16:05:47
Also in: linux-input

On Thu, Jan 14, 2021 at 4:23 PM Lee Jones [off-list ref] wrote:
Fixes the following W=1 kernel build warning(s):

 drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’:
 drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable]

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Benjamin Tissoires <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
Reviewed-by: Benjamin Tissoires <redacted>

Thanks for the cleanup :)

Cheers,
Benjamin
quoted hunk ↗ jump to hunk
---
 drivers/input/touchscreen/surface3_spi.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c
index 731454599fcee..1da23e5585a0d 100644
--- a/drivers/input/touchscreen/surface3_spi.c
+++ b/drivers/input/touchscreen/surface3_spi.c
@@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data,

 static void surface3_spi_process_touch(struct surface3_ts_data *ts_data, u8 *data)
 {
-       u16 timestamp;
        unsigned int i;
-       timestamp = get_unaligned_le16(&data[15]);

        for (i = 0; i < 13; i++) {
                struct surface3_ts_data_finger *finger;
--
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help