Hi,

Le jeudi 06 septembre 2018 à 08:13 +0100, David Howells a écrit :

Yann Droneaud [off-list ref] wrote:

quoted

This structure should not have been exposed to userspace in the
first
place: it's unusable by userspace as it is. It was incorrect to
have it
outside of #ifdef __KERNEL__ before commit 607ca46e97a1b ... 
...
All CODA_REQ_* defines internals to kernel side and not exchanged
with
userspace.

Please move them back to <linux/coda_psdev.h>

Is there any reason coda_psdev.h needs to be in include/linux/ rather
than fs/coda/?

It's a valid concern.

At first I thought the first lines (see below) could have been useful
for userspace:

  #define CODA_PSDEV_MAJOR 67
  #define MAX_CODADEVS  5    /* how many do we allow */


But the file was unsuable for a long long time so we can assume it's
usage by userspace is deprecated, then we could remove it from UAPI,
and moves its content back to include/linux.

As one could see include/linux/coda_psdev.h is not used outside of
fs/coda, moving the header here as you suggests seems to be the correct
solution.

Regards.

-- 
Yann Droneaud
OPTEYA