Re: [PATCH 3/3] staging: sm7xxfb: change return of sm7xx_vga_setup
From: Dan Carpenter <hidden>
Date: 2015-03-09 13:14:01
Also in:
linux-fbdev
From: Dan Carpenter <hidden>
Date: 2015-03-09 13:14:01
Also in:
linux-fbdev
On Sun, Mar 08, 2015 at 11:10:11PM +0530, Sudip Mukherjee wrote:
change return type of sm7xx_vga_setup() to void as we are not using the return type anywhere. if this function fails we fall back to the default configuration. Signed-off-by: Sudip Mukherjee <redacted>
Reviewed-by: Dan Carpenter <redacted> This patch is fine but if you wanted you could send a follow on which set it to SCREEN_X_RES, SCREEN_Y_RES, SCREEN_BPP if there were no options. Then remove the "if (smtc_scr_info.lfb_width != 0) " condition in smtcfb_pci_probe(). regards, dan carpenter