Re: [PATCH 1/1] kernel-power: Deletion of an unnecessary check before the function call "vfree"
From: Rafael J. Wysocki <hidden>
Date: 2014-11-18 23:11:05
Also in:
kernel-janitors, linux-pm
On Sunday, November 16, 2014 02:28:23 PM SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Sun, 16 Nov 2014 14:18:28 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted>
Queued up for 3.19-rc1, thanks!
quoted hunk ↗ jump to hunk
--- kernel/power/swap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/kernel/power/swap.c b/kernel/power/swap.c index aaa3261..337c7a9 100644 --- a/kernel/power/swap.c +++ b/kernel/power/swap.c@@ -1374,7 +1374,7 @@ out_clean: kthread_stop(data[thr].thr); vfree(data); } - if (page) vfree(page); + vfree(page); return ret; }
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.