Thread (1341 messages) 1341 messages, 165 authors, 2017-04-12

Re: [PATCH 1/1] kernel-audit: Deletion of an unnecessary check before the function call "audit_log_end" (or improve error handling?)

From: SF Markus Elfring <hidden>
Date: 2014-11-16 12:07:48
Also in: cocci, kernel-janitors

The original code is very clear, the new code works exactly the same but
it's not clear if the author forgot about handling errors from
audit_log_start().
We have got different expectations on source code clarity here.

So now someone will come along later and add:
	if (!ab)
		return;

We get a lot of mindless "add error handling" patches like that.
This is an interesting background information.

Do you eventually prefer to improve the affected error detection
and corresponding exception handling?
Will a condition check become absolutely necessary there?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help