Thread (22 messages) 22 messages, 5 authors, 2011-07-20

[tip:sched/urgent] sched: Avoid creating superfluous NUMA domains on non-NUMA systems

From: tip-bot for Peter Zijlstra <hidden>
Date: 2011-07-20 17:30:08
Subsystem: the rest · Maintainer: Linus Torvalds

Commit-ID:  d110235d2c331c4f79e0879f51104be79e17a469
Gitweb:     http://git.kernel.org/tip/d110235d2c331c4f79e0879f51104be79e17a469
Author:     Peter Zijlstra [off-list ref]
AuthorDate: Wed, 20 Jul 2011 18:42:57 +0200
Committer:  Ingo Molnar [off-list ref]
CommitDate: Wed, 20 Jul 2011 18:54:33 +0200

sched: Avoid creating superfluous NUMA domains on non-NUMA systems

When creating sched_domains, stop when we've covered the entire
target span instead of continuing to create domains, only to
later find they're redundant and throw them away again.

This avoids single node systems from touching funny NUMA
sched_domain creation code and reduces the risks of the new
SD_OVERLAP code.

Requested-by: Linus Torvalds [off-list ref]
Signed-off-by: Peter Zijlstra <redacted>
Cc: Anton Blanchard <redacted>
Cc: mahesh@linux.vnet.ibm.com
Cc: benh@kernel.crashing.org
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lkml.kernel.org/r/1311180177.29152.57.camel@twins
Signed-off-by: Ingo Molnar <redacted>
---
 kernel/sched.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 921adf6..14168c4 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7436,6 +7436,8 @@ static int build_sched_domains(const struct cpumask *cpu_map,
 			sd = build_sched_domain(tl, &d, cpu_map, attr, sd, i);
 			if (tl->flags & SDTL_OVERLAP || sched_feat(FORCE_SD_OVERLAP))
 				sd->flags |= SD_OVERLAP;
+			if (cpumask_equal(cpu_map, sched_domain_span(sd)))
+				break;
 		}
 
 		while (sd->child)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help