Re: [PATCH v2 3/9] fsldma: use channel name in printk output
From: Joe Perches <joe@perches.com>
Date: 2011-03-02 23:17:38
Also in:
linuxppc-dev
On Wed, 2011-03-02 at 14:23 -0800, Ira W. Snyder wrote:
quoted hunk ↗ jump to hunk
This makes debugging the driver much easier when multiple channels are running concurrently. In addition, you can see how much descriptor memory each channel has allocated via the dmapool API in sysfs. Signed-off-by: Ira W. Snyder <redacted> --- drivers/dma/fsldma.c | 60 +++++++++++++++++++++++++++---------------------- drivers/dma/fsldma.h | 1 + 2 files changed, 34 insertions(+), 27 deletions(-)diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 2e1af45..6e3d3d7 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c@@ -37,7 +37,7 @@ #include "fsldma.h" -static const char msg_ld_oom[] = "No free memory for link descriptor\n"; +static const char msg_ld_oom[] = "No free memory for link descriptor"; /* * Register Helpers@@ -207,7 +207,7 @@ static void dma_halt(struct fsldma_chan *chan) } if (!dma_is_idle(chan)) - dev_err(chan->dev, "DMA halt timeout!\n"); + dev_err(chan->dev, "%s: DMA halt timeout!\n", chan->name);
I suggest instead you add: #define chan_err(chan, fmt, arg...) \ dev_err(chan->dev, "%s: " fmt, chan->name, ##arg); #define chan_info(chan, fmt, arg...) \ dev_info(chan->dev, "%s: " fmt, chan->name, ##arg); #define chan_dbg(chan, fmt, arg...) \ dev_dbg(chan->dev, "%s: " fmt, chan->name, ##arg); and change the uses to be similar to: if (!dma_is_idle(chan)) chan_err(chan, "DMA halt timeout!\n"); etc...