Re: [PATCH] Prefix each line of multiline printk(KERN_<level> "foo\nbar") with KERN_<level>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2007-08-26 08:31:01
Also in:
linux-acpi, linux-ide, linux-mips, linux-mm, linux-scsi, netdev
On Fri, 24 Aug 2007, Joe Perches wrote:
Corrected printk calls with multiple output lines which did not correctly preface each line with KERN_<level> Fixed uses of some single lines with too many KERN_<level>
quoted hunk ↗ jump to hunk
--- a/arch/arm/kernel/ecard.c +++ b/arch/arm/kernel/ecard.c@@ -547,7 +547,8 @@ static void ecard_check_lockup(struct irq_desc *desc) if (last == jiffies) { lockup += 1; if (lockup > 1000000) { - printk(KERN_ERR "\nInterrupt lockup detected - " + printk(KERN_ERR "\n" + KERN_ERR "Interrupt lockup detected - " "disabling all expansion card interrupts\n"); desc->chip->mask(IRQ_EXPANSIONCARD);
What's the purpose of having lines printed with e.g. `KERN_ERR "\n"' only?
Shouldn't these just be removed?
Usually lines starting with `\n' are continuations, but given some other
module may call printk() in between, there's no guarantee continuations
appear on the same line.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds