Re: [PATCH 8/12] generic hweight{32,16,8}()
From: Bryan O'Sullivan <hidden>
Date: 2006-01-26 18:57:54
From: Bryan O'Sullivan <hidden>
Date: 2006-01-26 18:57:54
On Thu, 2006-01-26 at 12:36 +0900, Akinobu Mita wrote:
HAVE_ARCH_HWEIGHT_BITOPS is defined when the architecture has its own version of these functions.
All of this HAVE_ARCH_xxx stuff gave Linus heartburn a few weeks ago, and you're massively increasing its proliferation. How about putting each class of bitop into its own header file in asm-generic, and getting the arches that need each one to include the specific files it needs in its own bitops.h header? For example, the hweight stuff would go into asm-generic/bitops-hweight.h, and then asm-foo/bitops.h would just use #include <asm-generic/bitops-hweight.h> or else define its own if it didn't need the generic versions. <b