# Re: \[PATCH\] Documentation: livepatch: Point klp\_callbacks kernel-doc at livepatch\_external.h

- From: Jonathan Corbet \<corbet@lwn.net\>
- Date: 2026-09-07 15:49:05 
- List: live-patching
- Page: https://ratatoskr.run/live-patching/2026/09/17526208
- Thread: https://ratatoskr.run/live-patching/2026/09/17518172/t.md

```text
Karl Mehltretter [ref] writes:

> api.rst asks include/linux/livepatch.h for struct klp_callbacks.
> Commit dd590d4d57eb ("objtool/klp: Introduce klp diff subcommand for
> diffing object files") moved the structure and its kernel-doc comment
> to include/linux/livepatch_external.h. Since then the Object Types
> section renders the other four structures but not klp_callbacks.
>
> Add a directive for the new header.
>
> Fixes: dd590d4d57eb ("objtool/klp: Introduce klp diff subcommand for diffing object files")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <redacted>
> ---
>  Documentation/livepatch/api.rst | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/livepatch/api.rst b/Documentation/livepatch/api.rst
> index 78944b63d74b..2a98c517da9d 100644
> --- a/Documentation/livepatch/api.rst
> +++ b/Documentation/livepatch/api.rst
> @@ -27,4 +27,7 @@ Object Types
>  ============
>  
>  .. kernel-doc:: include/linux/livepatch.h
> -   :identifiers: klp_patch klp_object klp_func klp_callbacks klp_state
> +   :identifiers: klp_patch klp_object klp_func klp_state
> +
> +.. kernel-doc:: include/linux/livepatch_external.h
> +   :identifiers: klp_callbacks

Applied, thanks.

jon
```