# Re: \[PATCH 05/13\] kallsyms: refactor {,module\_}kallsyms\_on\_each\_symbol

- From: Miroslav Benes \<mbenes@suse.cz\>
- Date: 2021-02-01 14:03:42 
- List: live-patching
- Page: https://ratatoskr.run/live-patching/2021/02/6253735
- Thread: https://ratatoskr.run/linuxppc-dev/2021/01/6251270/t.md

```text
One more thing...

> @@ -4379,8 +4379,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
>  	unsigned int i;
>  	int ret;
>  
> -	module_assert_mutex();
> -
> +	mutex_lock(&module_mutex);
>  	list_for_each_entry(mod, &modules, list) {
>  		/* We hold module_mutex: no need for rcu_dereference_sched */
>  		struct mod_kallsyms *kallsyms = mod->kallsyms;

This was the last user of module_assert_mutex(), which can be removed now.

Miroslav
```