# Re: \[PATCH 04/13\] module: use RCU to synchronize find\_module

- From: Thiago Jung Bauermann \<hidden\>
- Date: 2021-01-29 21:31:26 
- List: live-patching
- Page: https://ratatoskr.run/live-patching/2021/01/6252127
- Thread: https://ratatoskr.run/linux-kbuild/2021/01/6251270/t.md

```text

Christoph Hellwig [ref] writes:

> On Thu, Jan 28, 2021 at 05:50:56PM -0300, Thiago Jung Bauermann wrote:
>> >  struct module *find_module(const char *name)
>> >  {
>> > -	module_assert_mutex();
>> 
>> Does it make sense to replace the assert above with the warn below (untested)?
>> 
>>      RCU_LOCKDEP_WARN(rcu_read_lock_sched_held());
>
> One caller actually holds module_mutex still.  And find_module_all,
> which implements the actual logic already asserts that either
> module_mutex is held or rcu_read_lock, so I don't tink we need an
> extra one here.

Ok, thanks for the clarification.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center
```
