# Re: \[PATCH net-next v8 07/15\] ibmveth: Add RX queue register helpers for MQ

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2026-11-17 01:35:01 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2026/11/17949503
- Thread: https://ratatoskr.run/netdev/2026/11/17900831/t.md

```text
On Mon,  9 Nov 2026 15:55:48 -0800 Mingming Cao wrote:
> +	rc = ibmveth_alloc_buffer_pools(adapter);
> +	if (rc) {
> +		unsigned long ua = adapter->vdev->unit_address;
> +		unsigned long lpar_rc;
>  
> -	if (lpar_rc != H_SUCCESS) {
> -		netdev_err(netdev, "h_register_logical_lan failed with %ld\n",
> -			   lpar_rc);
> -		netdev_err(netdev, "buffer TCE:0x%llx filter TCE:0x%llx rxq "
> -			   "desc:0x%llx MAC:0x%llx\n",
> -				     adapter->buffer_list_dma[0],
> -				     adapter->filter_list_dma,
> -				     rxq_desc.desc,
> -				     mac_address);
> -		rc = -ENONET;
> +		/* A kexec can leave the LAN registered by the old kernel
> +		 * (see ibmveth_register_logical_lan()); do not leave its
> +		 * buffers live in PHYP. H_PARAMETER if none is registered.
> +		 */
> +		do {
> +			lpar_rc = h_free_logical_lan(ua);
> +		} while (H_IS_LONG_BUSY(lpar_rc) || (lpar_rc == H_BUSY));

This loop is repeated in a number of places, you should probably factor
it out.

>  		goto out_free_queue_mem;

```
