# Re: \[PATCH v2 2/5\] dt-bindings: soc: fsl: layerscape-dcfg: add the LX2160A pad-mux child

- From: Vincent Jardin \<vjardin@free.fr\>
- Date: 2026-11-07 17:00:52 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2026/11/17890269
- Thread: https://ratatoskr.run/linux-gpio/2026/11/17855200/t.md

```text
Hi,

> > @@ -32,6 +32,7 @@ properties:
> >        - items:
> >            - enum:
> >                - fsl,ls1028a-dcfg
> > +              - fsl,lx2160a-dcfg
> >            - const: syscon
> >            - const: simple-mfd
> >  
> > @@ -62,6 +63,12 @@ properties:
> >  
> >    ranges: true
> >  
> > +  pinctrl:
> > +    $ref: /schemas/pinctrl/fsl,lx2160a-rcw-pinmux.yaml#
> 
> Why other children are bus-addressed and this one not? Such mixing is
> messy. Either this is a subdevice with its own addressing or not. Keep
> bindings consistent.

ok, I'll provide a v3 accordingly.

thanks for this comment,
  Vincent

```