[PATCHv2] dmaengine: fsldma: kill tasklet before removing channel

Subsystems: dma generic offload engine subsystem, freescale dma driver, the rest

2 messages, 2 authors, 2026-09-15 · open the first message on its own page

[PATCHv2] dmaengine: fsldma: kill tasklet before removing channel

From: Rosen Penev <hidden>
Date: 2026-09-10 20:28:49

Add tasklet_kill() in fsl_dma_chan_remove() to prevent a race where the
tasklet is scheduled by the IRQ handler and runs after the channel has been
freed.

Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <redacted>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 v2: split from series and wrap at 75 characters
 drivers/dma/fsldma.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 6ce0e5668dc2..5eca8ab23564 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -1207,6 +1207,7 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev,
 
 static void fsl_dma_chan_remove(struct fsldma_chan *chan)
 {
+	tasklet_kill(&chan->tasklet);
 	irq_dispose_mapping(chan->irq);
 	list_del(&chan->common.device_node);
 	iounmap(chan->regs);
-- 
2.55.0

Re: [PATCHv2] dmaengine: fsldma: kill tasklet before removing channel

From: Vinod Koul <vkoul@kernel.org>
Date: 2026-09-15 17:36:32

On Thu, 10 Sep 2026 13:28:46 -0700, Rosen Penev wrote:
Add tasklet_kill() in fsl_dma_chan_remove() to prevent a race where the
tasklet is scheduled by the IRQ handler and runs after the channel has been
freed.
Applied, thanks!

[1/1] dmaengine: fsldma: kill tasklet before removing channel
      commit: 32ac4723e5526c44e5a1f3b1586578c17647f2ef

Best regards,
-- 
~Vinod


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help