[PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example

Subsystems: documentation, linux for powerpc (32-bit and 64-bit), the rest

COLD40d

3 messages, 3 authors, 2026-09-06 · open the first message on its own page

[PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example

From: Karl Mehltretter <hidden>
Date: 2026-09-05 10:43:20

struct vas_setup_attr does not exist; the name is struct
vas_tx_win_open_attr.

Use struct vas_tx_win_open_attr.

Fixes: c12e38b1d52e ("Documentation/powerpc: VAS API")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <redacted>
---
 Documentation/arch/powerpc/vas-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/arch/powerpc/vas-api.rst b/Documentation/arch/powerpc/vas-api.rst
index 1d0d055356e3..00d98cfd95c9 100644
--- a/Documentation/arch/powerpc/vas-api.rst
+++ b/Documentation/arch/powerpc/vas-api.rst
@@ -265,7 +265,7 @@ Simple example
 		{
 			int rc, fd;
 			void *addr;
-			struct vas_setup_attr txattr;
+			struct vas_tx_win_open_attr txattr;
 
 			fd = open("/dev/crypto/nx-gzip", O_RDWR);
 			if (fd < 0) {
-- 
2.53.0

Re: [PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example

From: Randy Dunlap <rdunlap@infradead.org>
Date: 2026-09-05 17:37:16


On 9/5/26 3:43 AM, Karl Mehltretter wrote:
struct vas_setup_attr does not exist; the name is struct
vas_tx_win_open_attr.

Use struct vas_tx_win_open_attr.

Fixes: c12e38b1d52e ("Documentation/powerpc: VAS API")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <redacted>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
quoted hunk
---
 Documentation/arch/powerpc/vas-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/arch/powerpc/vas-api.rst b/Documentation/arch/powerpc/vas-api.rst
index 1d0d055356e3..00d98cfd95c9 100644
--- a/Documentation/arch/powerpc/vas-api.rst
+++ b/Documentation/arch/powerpc/vas-api.rst
@@ -265,7 +265,7 @@ Simple example
 		{
 			int rc, fd;
 			void *addr;
-			struct vas_setup_attr txattr;
+			struct vas_tx_win_open_attr txattr;
 
 			fd = open("/dev/crypto/nx-gzip", O_RDWR);
 			if (fd < 0) {
-- 
~Randy

Re: [PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example

From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Date: 2026-09-06 03:16:08

Karl Mehltretter [off-list ref] writes:
struct vas_setup_attr does not exist; the name is struct
vas_tx_win_open_attr.

Use struct vas_tx_win_open_attr.
Thanks for fixing this.
Fixes: c12e38b1d52e ("Documentation/powerpc: VAS API")
yup. Looks like this UAPI name was wrong since day one.

While at it - would you like to fix the ioctl definition too in the same
file?

                #define VAS_MAGIC 'v'
-               #define VAS_TX_WIN_OPEN _IOW(VAS_MAGIC, 1,
+               #define VAS_TX_WIN_OPEN _IOW(VAS_MAGIC, 0x20,
                                                struct vas_tx_win_open_attr)

                struct vas_tx_win_open_attr attr;



-ritesh

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help