# Re: \[patch 02/18\] randomize\_kstack: Provide add\_random\_kstack\_offset\_irqsoff()

- From: Kees Cook \<kees@kernel.org\>
- Date: 2026-07-09 16:23:48 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2026/07/17237741
- Thread: https://ratatoskr.run/linuxppc-dev/2026/07/17227033/t.md

```text
On Tue, Jul 07, 2026 at 09:06:02PM +0200, Thomas Gleixner wrote:
> add_random_kstack_offset() uses get/put_cpu_var() which is pointless
> overhead when it is invoked from low level entry code with interrupts
> disabled.
> 
> Provide a irqsoff() variant, which avoids that.
> 
> Signed-off-by: Thomas Gleixner <tglx@kernel.org>

Seems good. I don't think macro'izing the interior is worth it since
both cases are very short, with only the lockdep and raw bits changed.

Reviewed-by: Kees Cook <kees@kernel.org>

-Kees

-- 
Kees Cook

```
