[PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

COLD39d

7 messages, 4 authors, 2026-08-16 · open the first message on its own page

[PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.

From: Christian Zigotzky <hidden>
Date: 2026-07-01 13:03:33

Hello,

Here is the email without HTML (Sorry):

The Nemo board [1] doesn’t boot without this patch. Darren explained it really well:

Originally we initialised the PCI-e ports in setup arch, this is quite early, and it seems uses some kernel functions that were not recommended (They changed a whole lot of different platforms at the same time for the same reason)

After this we added the ISA bridge, then the kernel would init the IRQ contollers.

The patch that broke booting on the X1000 moved the pas_pci_init to a node in the machine description, where it called later in the boot sequence. Unfortunately this is after we've tried to add the i8259 contoller from the pas_init_IRQ. Since our ISA bridge can't be found until we've connected the PCI-e ports the system tries to write to registers that aren't yet mapped - result a kernel panic, but before console I/O has been initialised so it appears to be a hang. We had a similar problem when they were introducing Radix support.

My patch changes our code so that it works with the new kernel code in place. Basically I moved the code that adds the i8259 cascade to after we've scanned for the ISA bridge where I know it will work.

Hopefully this makes sense, shout out if it doesn't.

Regards
Darren

[1] https://en.wikipedia.org/wiki/AmigaOne_X1000

Signed-off-by: Christian Zigotzky <redacted>
---
 arch/powerpc/platforms/pasemi/pci.c   | 7 +++++++
 arch/powerpc/platforms/pasemi/setup.c | 7 ++++---
 2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c
index 2df955274652..7208c325bfc5 100644
--- a/arch/powerpc/platforms/pasemi/pci.c
+++ b/arch/powerpc/platforms/pasemi/pci.c
@@ -25,6 +25,8 @@
 
 #define PA_PXP_CFA(bus, devfn, off) (((bus) << 20) | ((devfn) << 12) | (off))
 
+extern void nemo_init_IRQ(void);
+
 static inline int pa_pxp_offset_valid(u8 bus, u8 devfn, int offset)
 {
 	/* Device 0 Function 0 is special: It's config space spans function 1 as
@@ -265,6 +267,11 @@ static int __init pas_add_bridge(struct device_node *dev)
 	 */
 	isa_bridge_find_early(hose);
 
+	/*
+	 * ISA brigde is now active, add the i8259 cascade (if needed)
+	 */
+	nemo_init_IRQ();
+
 	return 0;
 }
 
diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c
index d03b41336901..eec74611be46 100644
--- a/arch/powerpc/platforms/pasemi/setup.c
+++ b/arch/powerpc/platforms/pasemi/setup.c
@@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct irq_desc *desc)
 	chip->irq_eoi(&desc->irq_data);
 }
 
-static void __init nemo_init_IRQ(struct mpic *mpic)
+void nemo_init_IRQ(void)
 {
 	struct device_node *np;
 	int gpio_virq;
+        struct mpic *mpic;
+
 	/* Connect the SB600's legacy i8259 controller */
 	np = of_find_node_by_path("/pxp@0,e0000000");
 	i8259_init(np, 0);
@@ -228,6 +230,7 @@ static void __init nemo_init_IRQ(struct mpic *mpic)
 	irq_set_chained_handler(gpio_virq, sb600_8259_cascade);
 	mpic_unmask_irq(irq_get_irq_data(gpio_virq));
 
+	mpic = irq_get_chip_data(gpio_virq);
 	irq_set_default_domain(mpic->irqhost);
 }
 
@@ -298,8 +301,6 @@ static __init void pas_init_IRQ(void)
 		mpic_unmask_irq(irq_get_irq_data(nmi_virq));
 	}
 
-	nemo_init_IRQ(mpic);
-
 	of_node_put(mpic_node);
 	of_node_put(root);
 }
-- 
2.55.0.windows.1

Re: [PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.

From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
Date: 2026-07-27 13:43:24


Le 01/07/2026 à 14:59, Christian Zigotzky a écrit :
Hello,

Here is the email without HTML (Sorry):

The Nemo board [1] doesn’t boot without this patch. Darren explained it really well:

Originally we initialised the PCI-e ports in setup arch, this is quite early, and it seems uses some kernel functions that were not recommended (They changed a whole lot of different platforms at the same time for the same reason)

After this we added the ISA bridge, then the kernel would init the IRQ contollers.

The patch that broke booting on the X1000 moved the pas_pci_init to a node in the machine description, where it called later in the boot sequence. Unfortunately this is after we've tried to add the i8259 contoller from the pas_init_IRQ. Since our ISA bridge can't be found until we've connected the PCI-e ports the system tries to write to registers that aren't yet mapped - result a kernel panic, but before console I/O has been initialised so it appears to be a hang. We had a similar problem when they were introducing Radix support.

My patch changes our code so that it works with the new kernel code in place. Basically I moved the code that adds the i8259 cascade to after we've scanned for the ISA bridge where I know it will work.

Hopefully this makes sense, shout out if it doesn't.

Regards
Darren

[1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FAmigaOne_X1000&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cb415e9e7a26c4d8e3c6b08ded770c1b7%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639185077045605675%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C60000%7C%7C%7C&sdata=EgGtT9Kj7aqkWWcIIxfPpYRulro8rUA%2F%2Bsp9bhy%2Bjqo%3D&reserved=0

Signed-off-by: Christian Zigotzky <redacted>

The commit message will look strange when picking-up this email, you 
should resend with a cleaned commit message.
quoted hunk
---
  arch/powerpc/platforms/pasemi/pci.c   | 7 +++++++
  arch/powerpc/platforms/pasemi/setup.c | 7 ++++---
  2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c
index 2df955274652..7208c325bfc5 100644
--- a/arch/powerpc/platforms/pasemi/pci.c
+++ b/arch/powerpc/platforms/pasemi/pci.c
@@ -25,6 +25,8 @@
  
  #define PA_PXP_CFA(bus, devfn, off) (((bus) << 20) | ((devfn) << 12) | (off))
  
+extern void nemo_init_IRQ(void);
+
Should be better in arch/powerpc/platforms/pasemi/pasemi.h
quoted hunk
  static inline int pa_pxp_offset_valid(u8 bus, u8 devfn, int offset)
  {
  	/* Device 0 Function 0 is special: It's config space spans function 1 as
@@ -265,6 +267,11 @@ static int __init pas_add_bridge(struct device_node *dev)
  	 */
  	isa_bridge_find_early(hose);
  
+	/*
+	 * ISA brigde is now active, add the i8259 cascade (if needed)
+	 */
+	nemo_init_IRQ();
+
  	return 0;
  }
  
diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c
index d03b41336901..eec74611be46 100644
--- a/arch/powerpc/platforms/pasemi/setup.c
+++ b/arch/powerpc/platforms/pasemi/setup.c
@@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct irq_desc *desc)
  	chip->irq_eoi(&desc->irq_data);
  }
  
-static void __init nemo_init_IRQ(struct mpic *mpic)
+void nemo_init_IRQ(void)
  {
  	struct device_node *np;
  	int gpio_virq;
+        struct mpic *mpic;
+
  	/* Connect the SB600's legacy i8259 controller */
  	np = of_find_node_by_path("/pxp@0,e0000000");
  	i8259_init(np, 0);
@@ -228,6 +230,7 @@ static void __init nemo_init_IRQ(struct mpic *mpic)
  	irq_set_chained_handler(gpio_virq, sb600_8259_cascade);
  	mpic_unmask_irq(irq_get_irq_data(gpio_virq));
  
+	mpic = irq_get_chip_data(gpio_virq);
  	irq_set_default_domain(mpic->irqhost);
  }
  
@@ -298,8 +301,6 @@ static __init void pas_init_IRQ(void)
  		mpic_unmask_irq(irq_get_irq_data(nmi_virq));
  	}
  
-	nemo_init_IRQ(mpic);
-
  	of_node_put(mpic_node);
  	of_node_put(root);
  }
Build fails:

   CC      arch/powerpc/platforms/pasemi/setup.o
arch/powerpc/platforms/pasemi/setup.c:217:6: error: no previous 
prototype for 'nemo_init_IRQ' [-Werror=missing-prototypes]
   217 | void nemo_init_IRQ(void)
       |      ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:289: 
arch/powerpc/platforms/pasemi/setup.o] Error 1
make[4]: *** [scripts/Makefile.build:549: arch/powerpc/platforms/pasemi] 
Error 2
make[3]: *** [scripts/Makefile.build:549: arch/powerpc/platforms] Error 2
make[2]: *** [scripts/Makefile.build:549: arch/powerpc] Error 2
make[1]: *** [/home/chleroy/linux-powerpc/Makefile:2184: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2

Re: [PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.

From: Christian Zigotzky <hidden>
Date: 2026-07-28 12:50:59

On 27/07/26 15:43, Christophe Leroy (CS GROUP) wrote:
 >
 > Should be better in arch/powerpc/platforms/pasemi/pasemi.h
 >

Hello Christophe,

Thank you for your answer. I modified the patch today. The Nemo board 
boots without any problems if I compile the RC5 of kernel 7.2 with this 
patch.

Could you please check the following modified patch?

Thanks,
Christian

---

powerpc/pasemi: Move Nemo i8259 initialization to pci.c

The Nemo board requires the PCIe ports to be initialized before the
SB600 ISA bridge can be accessed.

Since pas_pci_init() is now called later during boot, the i8259
initialization in pas_init_IRQ() happens too early and accesses
registers that are not yet mapped, preventing the board from booting.

Move the Nemo-specific i8259 initialization to pas_add_bridge(),
after the ISA bridge has been discovered.

Suggested-by: Darren Stevens <redacted>
Tested-by: Christian Zigotzky <redacted>
Signed-off-by: Christian Zigotzky <redacted>

---
v2:
- Move Nemo i8259 initialization out of pas_init_IRQ() and into
   pas_add_bridge() after the ISA bridge has been discovered.
- Change nemo_init_IRQ() to no longer depend on the MPIC instance passed
   from the IRQ setup path.
- Move the nemo_init_IRQ() declaration to pasemi.h and add a no-op stub
   for non-Nemo builds.
- Fix missing prototype warning reported by Christophe Leroy.
- Fix indentation and clean up the commit message.

diff -rupN a/arch/powerpc/platforms/pasemi/pasemi.h 
b/arch/powerpc/platforms/pasemi/pasemi.h
--- a/arch/powerpc/platforms/pasemi/pasemi.h    2026-07-26 
23:45:48.000000000 +0200
+++ b/arch/powerpc/platforms/pasemi/pasemi.h    2026-07-28 
07:44:31.924168227 +0200
@@ -7,6 +7,12 @@ extern void pas_pci_init(void);
  struct pci_dev;
  extern void pas_pci_dma_dev_setup(struct pci_dev *dev);

+#ifdef CONFIG_PPC_PASEMI_NEMO
+extern void __init nemo_init_IRQ(void);
+#else
+static inline void __init nemo_init_IRQ(void) { }
+#endif
+
  void __iomem *__init pasemi_pci_getcfgaddr(struct pci_dev *dev, int 
offset);

  extern void __init pasemi_map_registers(void);
diff -rupN a/arch/powerpc/platforms/pasemi/pci.c 
b/arch/powerpc/platforms/pasemi/pci.c
--- a/arch/powerpc/platforms/pasemi/pci.c    2026-07-26 
23:45:48.000000000 +0200
+++ b/arch/powerpc/platforms/pasemi/pci.c    2026-07-28 
07:34:37.036634023 +0200
@@ -265,6 +265,11 @@ static int __init pas_add_bridge(struct
       */
      isa_bridge_find_early(hose);

+    /*
+     * ISA bridge is now active, add the i8259 cascade (if needed)
+     */
+    nemo_init_IRQ();
+
      return 0;
  }
diff -rupN a/arch/powerpc/platforms/pasemi/setup.c 
b/arch/powerpc/platforms/pasemi/setup.c
--- a/arch/powerpc/platforms/pasemi/setup.c    2026-07-26 
23:45:48.000000000 +0200
+++ b/arch/powerpc/platforms/pasemi/setup.c    2026-07-28 
07:54:54.147863161 +0200
@@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct ir
      chip->irq_eoi(&desc->irq_data);
  }

-static void __init nemo_init_IRQ(struct mpic *mpic)
+void __init nemo_init_IRQ(void)
  {
      struct device_node *np;
      int gpio_virq;
+    struct mpic *mpic;
+
      /* Connect the SB600's legacy i8259 controller */
      np = of_find_node_by_path("/pxp@0,e0000000");
      i8259_init(np, 0);
@@ -228,14 +230,10 @@ static void __init nemo_init_IRQ(struct
      irq_set_chained_handler(gpio_virq, sb600_8259_cascade);
      mpic_unmask_irq(irq_get_irq_data(gpio_virq));

+    mpic = irq_get_chip_data(gpio_virq);
      irq_set_default_domain(mpic->irqhost);
  }

-#else
-
-static inline void nemo_init_IRQ(struct mpic *mpic)
-{
-}
  #endif

  static __init void pas_init_IRQ(void)
@@ -297,9 +295,7 @@ static __init void pas_init_IRQ(void)
          irq_set_irq_type(nmi_virq, IRQ_TYPE_EDGE_RISING);
          mpic_unmask_irq(irq_get_irq_data(nmi_virq));
      }
-
-    nemo_init_IRQ(mpic);
-
+
      of_node_put(mpic_node);
      of_node_put(root);
  }



Re: [PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.

From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
Date: 2026-07-31 16:33:24


Le 28/07/2026 à 14:50, Christian Zigotzky a écrit :
On 27/07/26 15:43, Christophe Leroy (CS GROUP) wrote:
 >
 > Should be better in arch/powerpc/platforms/pasemi/pasemi.h
 >

Hello Christophe,

Thank you for your answer. I modified the patch today. The Nemo board 
boots without any problems if I compile the RC5 of kernel 7.2 with this 
patch.

Could you please check the following modified patch?
b4 doesn't see it as a patch. Can you resend as a regular patch ?

$ b4 shazam --single-message 
f5ed5a79-4235-31b6-5bd9-c68d1a6b50cf@xenosoft.de
Single-message mode, ignoring any follow-ups
Grabbing thread from 
lore.kernel.org/all/f5ed5a79-4235-31b6-5bd9-c68d1a6b50cf@xenosoft.de/t.mbox.gz
Analyzing 1 messages in the thread
No patches found.

Thanks
Christophe
quoted hunk
Thanks,
Christian

---

powerpc/pasemi: Move Nemo i8259 initialization to pci.c

The Nemo board requires the PCIe ports to be initialized before the
SB600 ISA bridge can be accessed.

Since pas_pci_init() is now called later during boot, the i8259
initialization in pas_init_IRQ() happens too early and accesses
registers that are not yet mapped, preventing the board from booting.

Move the Nemo-specific i8259 initialization to pas_add_bridge(),
after the ISA bridge has been discovered.

Suggested-by: Darren Stevens <redacted>
Tested-by: Christian Zigotzky <redacted>
Signed-off-by: Christian Zigotzky <redacted>

---
v2:
- Move Nemo i8259 initialization out of pas_init_IRQ() and into
   pas_add_bridge() after the ISA bridge has been discovered.
- Change nemo_init_IRQ() to no longer depend on the MPIC instance passed
   from the IRQ setup path.
- Move the nemo_init_IRQ() declaration to pasemi.h and add a no-op stub
   for non-Nemo builds.
- Fix missing prototype warning reported by Christophe Leroy.
- Fix indentation and clean up the commit message.

diff -rupN a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/ 
platforms/pasemi/pasemi.h
--- a/arch/powerpc/platforms/pasemi/pasemi.h    2026-07-26 
23:45:48.000000000 +0200
+++ b/arch/powerpc/platforms/pasemi/pasemi.h    2026-07-28 
07:44:31.924168227 +0200
@@ -7,6 +7,12 @@ extern void pas_pci_init(void);
  struct pci_dev;
  extern void pas_pci_dma_dev_setup(struct pci_dev *dev);

+#ifdef CONFIG_PPC_PASEMI_NEMO
+extern void __init nemo_init_IRQ(void);
+#else
+static inline void __init nemo_init_IRQ(void) { }
+#endif
+
  void __iomem *__init pasemi_pci_getcfgaddr(struct pci_dev *dev, int 
offset);

  extern void __init pasemi_map_registers(void);
diff -rupN a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/ 
platforms/pasemi/pci.c
--- a/arch/powerpc/platforms/pasemi/pci.c    2026-07-26 
23:45:48.000000000 +0200
+++ b/arch/powerpc/platforms/pasemi/pci.c    2026-07-28 
07:34:37.036634023 +0200
@@ -265,6 +265,11 @@ static int __init pas_add_bridge(struct
       */
      isa_bridge_find_early(hose);

+    /*
+     * ISA bridge is now active, add the i8259 cascade (if needed)
+     */
+    nemo_init_IRQ();
+
      return 0;
  }
diff -rupN a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/ 
platforms/pasemi/setup.c
--- a/arch/powerpc/platforms/pasemi/setup.c    2026-07-26 
23:45:48.000000000 +0200
+++ b/arch/powerpc/platforms/pasemi/setup.c    2026-07-28 
07:54:54.147863161 +0200
@@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct ir
      chip->irq_eoi(&desc->irq_data);
  }

-static void __init nemo_init_IRQ(struct mpic *mpic)
+void __init nemo_init_IRQ(void)
  {
      struct device_node *np;
      int gpio_virq;
+    struct mpic *mpic;
+
      /* Connect the SB600's legacy i8259 controller */
      np = of_find_node_by_path("/pxp@0,e0000000");
      i8259_init(np, 0);
@@ -228,14 +230,10 @@ static void __init nemo_init_IRQ(struct
      irq_set_chained_handler(gpio_virq, sb600_8259_cascade);
      mpic_unmask_irq(irq_get_irq_data(gpio_virq));

+    mpic = irq_get_chip_data(gpio_virq);
      irq_set_default_domain(mpic->irqhost);
  }

-#else
-
-static inline void nemo_init_IRQ(struct mpic *mpic)
-{
-}
  #endif

  static __init void pas_init_IRQ(void)
@@ -297,9 +295,7 @@ static __init void pas_init_IRQ(void)
          irq_set_irq_type(nmi_virq, IRQ_TYPE_EDGE_RISING);
          mpic_unmask_irq(irq_get_irq_data(nmi_virq));
      }
-
-    nemo_init_IRQ(mpic);
-
+
      of_node_put(mpic_node);
      of_node_put(root);
  }


Re: [PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.

From: kernel test robot <hidden>
Date: 2026-08-14 15:42:54

Hi Christian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v7.2-rc7 next-20260813]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Zigotzky/Connecting-the-SB600-s-i8259-controller-rather-in-pasemi-s-pci-c-than-in-pasemi-s-setup-c/20260813-054214
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20260701125941.906-2-chzigotzky%40xenosoft.de
patch subject: [PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.
config: powerpc64-randconfig-r052-20260814 (https://download.01.org/0day-ci/archive/20260814/202608142355.4AeDorvg-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260814/202608142355.4AeDorvg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202608142355.4AeDorvg-lkp@intel.com/

All warnings (new ones prefixed by >>):
quoted
arch/powerpc/platforms/pasemi/setup.c:217:6: warning: no previous prototype for function 'nemo_init_IRQ' [-Wmissing-prototypes]
     217 | void nemo_init_IRQ(void)
         |      ^
   arch/powerpc/platforms/pasemi/setup.c:217:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     217 | void nemo_init_IRQ(void)
         | ^
         | static 
   1 warning generated.


vim +/nemo_init_IRQ +217 arch/powerpc/platforms/pasemi/setup.c

   216	
 > 217	void nemo_init_IRQ(void)
   218	{
   219		struct device_node *np;
   220		int gpio_virq;
   221	        struct mpic *mpic;
   222	
   223		/* Connect the SB600's legacy i8259 controller */
   224		np = of_find_node_by_path("/pxp@0,e0000000");
   225		i8259_init(np, 0);
   226		of_node_put(np);
   227	
   228		gpio_virq = irq_create_mapping(NULL, 3);
   229		irq_set_irq_type(gpio_virq, IRQ_TYPE_LEVEL_HIGH);
   230		irq_set_chained_handler(gpio_virq, sb600_8259_cascade);
   231		mpic_unmask_irq(irq_get_irq_data(gpio_virq));
   232	
   233		mpic = irq_get_chip_data(gpio_virq);
   234		irq_set_default_domain(mpic->irqhost);
   235	}
   236	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.

From: Christian Zigotzky <hidden>
Date: 2026-08-15 09:58:04

On 14/08/26 17:42, kernel test robot wrote:
 > Hi Christian,
 >
 > kernel test robot noticed the following build warnings:
 >
 > [auto build test WARNING on powerpc/next]
 > [also build test WARNING on powerpc/fixes linus/master v7.2-rc7 
next-20260813]
 > [If your patch is applied to the wrong git tree, kindly drop us a note.
 > And when submitting patch, we suggest to use '--base' as documented in
 > https://git-scm.com/docs/git-format-patch#_base_tree_information]
 >
 > url: 
https://github.com/intel-lab-lkp/linux/commits/Christian-Zigotzky/Connecting-the-SB600-s-i8259-controller-rather-in-pasemi-s-pci-c-than-in-pasemi-s-setup-c/20260813-054214
 >
 > All warnings (new ones prefixed by >>):
 >
 >>> arch/powerpc/platforms/pasemi/setup.c:217:6: warning: no previous 
prototype for function 'nemo_init_IRQ' [-Wmissing-prototypes]

This is the old patch.

Here is the new patch with pasemi.h: 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260801043458.12500-1-chzigotzky@xenosoft.de/

Thanks

-- 
Sent with BrassMonkey 34.3.1 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_34.3.1)

Re: [PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.

From: Philip Li <hidden>
Date: 2026-08-16 05:52:32

On Sat, Aug 15, 2026 at 11:56:56AM +0200, Christian Zigotzky wrote:
On 14/08/26 17:42, kernel test robot wrote:
quoted
Hi Christian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v7.2-rc7
next-20260813]
quoted
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Christian-Zigotzky/Connecting-the-SB600-s-i8259-controller-rather-in-pasemi-s-pci-c-than-in-pasemi-s-setup-c/20260813-054214

All warnings (new ones prefixed by >>):
quoted
quoted
arch/powerpc/platforms/pasemi/setup.c:217:6: warning: no previous
prototype for function 'nemo_init_IRQ' [-Wmissing-prototypes]

This is the old patch.
Sorry about this meaningless report, we will improve the bot to check
new patches to avoid such report.
Here is the new patch with pasemi.h: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260801043458.12500-1-chzigotzky@xenosoft.de/

Thanks

-- 
Sent with BrassMonkey 34.3.1 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_34.3.1)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help