# Re: \[PATCH v6 14/20\] dma-direct: return struct page from dma\_direct\_alloc\_from\_pool()

- From: Catalin Marinas \<catalin.marinas@arm.com\>
- Date: 2026-06-09 13:46:15 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2026/06/17109501
- Thread: https://ratatoskr.run/linux-iommu/2026/06/17087574/t.md

```text
On Thu, Jun 04, 2026 at 02:09:53PM +0530, Aneesh Kumar K.V (Arm) wrote:
> Commit 5b138c534fda ("dma-direct: factor out a dma_direct_alloc_from_pool
> helper") changed dma_direct_alloc_from_pool() to return the CPU address
> from dma_alloc_from_pool(). That fits dma_direct_alloc(), but
> dma_direct_alloc_pages() also uses the helper and expects a struct page *.
> 
> Fix this by making dma_direct_alloc_from_pool() return the struct page *
> again, and pass the CPU address back through an out-parameter for the
> dma_direct_alloc() caller.
> 
> Fixes: 5b138c534fda ("dma-direct: factor out a dma_direct_alloc_from_pool helper")
> Cc: <redacted>
> 
> Tested-by: Michael Kelley <redacted>
> Tested-by: Mostafa Saleh <smostafa@google.com>
> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>

Nit: remove the empty line after Cc: stable. It may confuse tooling.

-- 
Catalin

```