[PATCHv2] powerpc/44x: Set GPIO chip parent

Subsystems: linux for powerpc (32-bit and 64-bit), linux for powerpc embedded ppc4xx, the rest

7 messages, 4 authors, 2026-08-03 · open the first message on its own page

[PATCHv2] powerpc/44x: Set GPIO chip parent

From: Rosen Penev <hidden>
Date: 2026-05-17 06:38:11

The PPC4xx GPIO driver stopped assigning an explicit parent
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
Signed-off-by: Rosen Penev <redacted>
---
 arch/powerpc/platforms/44x/gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
index aea0d913b59d..4413a94cf7a6 100644
--- a/arch/powerpc/platforms/44x/gpio.c
+++ b/arch/powerpc/platforms/44x/gpio.c

@@ -169,6 +169,7 @@ static int ppc4xx_gpio_probe(struct platform_device *ofdev)
 
 	gc = &chip->gc;
 
+	gc->parent = dev;
 	gc->base = -1;
 	gc->ngpio = 32;
 	gc->direction_input = ppc4xx_gpio_dir_in;

-- 
2.54.0

Re: [PATCHv2] powerpc/44x: Set GPIO chip parent

From: Linus Walleij <linusw@kernel.org>
Date: 2026-05-17 10:47:19

On Sun, May 17, 2026 at 8:38 AM Rosen Penev [off-list ref] wrote:

The PPC4xx GPIO driver stopped assigning an explicit parent
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
Signed-off-by: Rosen Penev <redacted>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [PATCHv2] powerpc/44x: Set GPIO chip parent

From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
Date: 2026-05-20 13:15:34


Le 17/05/2026 à 08:37, Rosen Penev a écrit :

The PPC4xx GPIO driver stopped assigning an explicit parent
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
Signed-off-by: Rosen Penev <redacted>

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>

quoted hunk

---
  arch/powerpc/platforms/44x/gpio.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
index aea0d913b59d..4413a94cf7a6 100644
--- a/arch/powerpc/platforms/44x/gpio.c
+++ b/arch/powerpc/platforms/44x/gpio.c

@@ -169,6 +169,7 @@ static int ppc4xx_gpio_probe(struct platform_device *ofdev)
  
  	gc = &chip->gc;
  
+	gc->parent = dev;
  	gc->base = -1;
  	gc->ngpio = 32;
  	gc->direction_input = ppc4xx_gpio_dir_in;

Re: [PATCHv2] powerpc/44x: Set GPIO chip parent

From: Rosen Penev <hidden>
Date: 2026-07-17 19:05:47

On Sat, May 16, 2026 at 11:38 PM Rosen Penev [off-list ref] wrote:

The PPC4xx GPIO driver stopped assigning an explicit parent
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")

Did I forget to ping someone?

quoted hunk

Signed-off-by: Rosen Penev <redacted>
---
 arch/powerpc/platforms/44x/gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
index aea0d913b59d..4413a94cf7a6 100644
--- a/arch/powerpc/platforms/44x/gpio.c
+++ b/arch/powerpc/platforms/44x/gpio.c

@@ -169,6 +169,7 @@ static int ppc4xx_gpio_probe(struct platform_device *ofdev)

        gc = &chip->gc;

+       gc->parent = dev;
        gc->base = -1;
        gc->ngpio = 32;
        gc->direction_input = ppc4xx_gpio_dir_in;
--

2.54.0

Re: [PATCHv2] powerpc/44x: Set GPIO chip parent

From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
Date: 2026-07-30 05:46:05


Le 17/07/2026 à 21:05, Rosen Penev a écrit :

On Sat, May 16, 2026 at 11:38 PM Rosen Penev [off-list ref] wrote:

quoted

The PPC4xx GPIO driver stopped assigning an explicit parent
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")

Did I forget to ping someone?

Probably not, but afterwards you sent your series which moves the driver 
into drivers/gpio/ and which does the same, so this one was flagged 
"superseeded" in Patchwork 
(https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260517063754.21819-1-rosenp@gmail.com/)

I put it back to 'new'. Maddy, can you pick it up ?

Christophe

quoted

Signed-off-by: Rosen Penev <redacted>
---
  arch/powerpc/platforms/44x/gpio.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
index aea0d913b59d..4413a94cf7a6 100644
--- a/arch/powerpc/platforms/44x/gpio.c
+++ b/arch/powerpc/platforms/44x/gpio.c

@@ -169,6 +169,7 @@ static int ppc4xx_gpio_probe(struct platform_device *ofdev)

         gc = &chip->gc;

+       gc->parent = dev;
         gc->base = -1;
         gc->ngpio = 32;
         gc->direction_input = ppc4xx_gpio_dir_in;
--

2.54.0

Re: [PATCHv2] powerpc/44x: Set GPIO chip parent

From: Madhavan Srinivasan <maddy@linux.ibm.com>
Date: 2026-07-31 11:55:51

On 7/30/26 11:15 AM, Christophe Leroy (CS GROUP) wrote:


Le 17/07/2026 à 21:05, Rosen Penev a écrit :

quoted

On Sat, May 16, 2026 at 11:38 PM Rosen Penev [off-list ref] wrote:

quoted

The PPC4xx GPIO driver stopped assigning an explicit parent
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper 
platform driver")

Did I forget to ping someone?

Probably not, but afterwards you sent your series which moves the 
driver into drivers/gpio/ and which does the same, so this one was 
flagged "superseeded" in Patchwork 
(https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260517063754.21819-1-rosenp@gmail.com/)

I put it back to 'new'. Maddy, can you pick it up ?

yes, i have added this to my next-test
Maddy

Christophe

quoted

Signed-off-by: Rosen Penev <redacted>
---
  arch/powerpc/platforms/44x/gpio.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/44x/gpio.c

b/arch/powerpc/platforms/44x/gpio.c
index aea0d913b59d..4413a94cf7a6 100644

--- a/arch/powerpc/platforms/44x/gpio.c
+++ b/arch/powerpc/platforms/44x/gpio.c

@@ -169,6 +169,7 @@ static int ppc4xx_gpio_probe(struct

platform_device *ofdev)

         gc = &chip->gc;

+       gc->parent = dev;
         gc->base = -1;
         gc->ngpio = 32;
         gc->direction_input = ppc4xx_gpio_dir_in;
-- 
2.54.0

Re: [PATCHv2] powerpc/44x: Set GPIO chip parent

From: Madhavan Srinivasan <maddy@linux.ibm.com>
Date: 2026-08-03 06:57:42

On Sat, 16 May 2026 23:37:54 -0700, Rosen Penev wrote:

The PPC4xx GPIO driver stopped assigning an explicit parent
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

[...]

Applied to powerpc/next.

[1/1] powerpc/44x: Set GPIO chip parent
      https://git.kernel.org/powerpc/c/b9254d222d0b38cc6f7b73119fad6316f65278be

cheers

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help