[PATCH] powerpc/44x: Set GPIO chip firmware node

Subsystems: linux for powerpc (32-bit and 64-bit), linux for powerpc embedded ppc4xx, the rest

STALE150d

3 messages, 2 authors, 2026-05-17 · open the first message on its own page

[PATCH] powerpc/44x: Set GPIO chip firmware node

From: Rosen Penev <hidden>
Date: 2026-05-15 23:19:32

The PPC4xx GPIO driver stopped assigning an explicit firmware node
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
Signed-off-by: Rosen Penev <redacted>
---
 arch/powerpc/platforms/44x/gpio.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
index d5824b7747b3..4d5176aa6895 100644
--- a/arch/powerpc/platforms/44x/gpio.c
+++ b/arch/powerpc/platforms/44x/gpio.c
@@ -169,6 +169,8 @@ static int ppc4xx_gpio_probe(struct platform_device *ofdev)
 
 	gc = &chip->gc;
 
+	gc->parent = dev;
+	gc->fwnode = dev_fwnode(dev);
 	gc->base = -1;
 	gc->ngpio = 32;
 	gc->direction_input = ppc4xx_gpio_dir_in;
-- 
2.54.0

Re: [PATCH] powerpc/44x: Set GPIO chip firmware node

From: Linus Walleij <linusw@kernel.org>
Date: 2026-05-16 14:55:42

On Sat, May 16, 2026 at 1:19 AM Rosen Penev [off-list ref] wrote:
The PPC4xx GPIO driver stopped assigning an explicit firmware node
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
Signed-off-by: Rosen Penev <redacted>
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [PATCH] powerpc/44x: Set GPIO chip firmware node

From: Rosen Penev <hidden>
Date: 2026-05-17 05:44:20

On Sat, May 16, 2026 at 7:55 AM Linus Walleij [off-list ref] wrote:
On Sat, May 16, 2026 at 1:19 AM Rosen Penev [off-list ref] wrote:
quoted
The PPC4xx GPIO driver stopped assigning an explicit firmware node
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
Signed-off-by: Rosen Penev <redacted>
Reviewed-by: Linus Walleij <linusw@kernel.org>
dev was needed, not fwnode. Which makes sense as this is specified in dts.

https://patch.msgid.link/20260427-gpio-mmio-more-v3-1-fe1882351424@kernel.org
fixes this but that's not in a released kernel.
Yours,
Linus Walleij

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help