[PATCH] PCI: pnv_php: Fix smatch warnings about "address of NULL pointer"
DORMANTno replies
From: <hidden>
Date: 2026-01-05 12:25:54
Also in:
linux-pci, lkml
Subsystem:
linux for powerpc (32-bit and 64-bit), pci subsystem, the rest · Maintainers:
Madhavan Srinivasan, Bjorn Helgaas, Linus Torvalds
From: sunliming <redacted> Fix below smatch warnings: drivers/pci/hotplug/pnv_php.c:710 pnv_php_alloc_slot() warn: address of NULL pointer 'php_slot->bus' Reported-by: kernel test robot <redacted> Reported-by: Dan Carpenter <redacted> Closes: https://lore.kernel.org/r/202601050123.5JEZ4Znh-lkp@intel.com/ (local) Signed-off-by: sunliming <redacted> --- drivers/pci/hotplug/pnv_php.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c
index c5345bff9a55..a22b8d69a479 100644
--- a/drivers/pci/hotplug/pnv_php.c
+++ b/drivers/pci/hotplug/pnv_php.c@@ -801,6 +801,9 @@ static struct pnv_php_slot *pnv_php_alloc_slot(struct device_node *dn) return NULL; } + php_slot->bus = bus; + php_slot->pdev = bus->self; + /* Allocate workqueue for this slot's interrupt handling */ php_slot->wq = alloc_workqueue("pciehp-%s", 0, 0, php_slot->name); if (!php_slot->wq) {
@@ -818,8 +821,6 @@ static struct pnv_php_slot *pnv_php_alloc_slot(struct device_node *dn) kref_init(&php_slot->kref); php_slot->state = PNV_PHP_STATE_INITIALIZED; php_slot->dn = dn; - php_slot->pdev = bus->self; - php_slot->bus = bus; php_slot->id = id; php_slot->power_state_check = false; php_slot->slot.ops = &php_slot_ops;
--
2.25.1