Thread (34 messages) 34 messages, 7 authors, 2025-10-06

Re: [PATCH v1 3/9] parisc: Convert DMA map_page to map_phys interface

From: "Leon Romanovsky" <leon@kernel.org>
Date: 2025-10-06 04:04:12
Also in: linux-alpha, linux-iommu, linux-mips, lkml, sparclinux, virtualization, xen-devel


On Mon, Oct 6, 2025, at 02:31, Jason Gunthorpe wrote:
On Sun, Oct 05, 2025 at 04:22:59PM +0300, Leon Romanovsky wrote:
quoted
@@ -582,7 +582,7 @@ ccio_io_pdir_entry(__le64 *pdir_ptr, space_t sid, unsigned long vba,
        ** Grab virtual index [0:11]
        ** Deposit virt_idx bits into I/O PDIR word
        */
-       asm volatile ("lci %%r0(%1), %0" : "=r" (ci) : "r" (vba));
+       asm volatile ("lci %%r0(%1), %0" : "=r" (ci) : "r" (pba));
Don't know how I missed this, but this is the virtual address for the
cache invalidate James mentioned

So the optimal is to drop the lpa() and to use phys_to_virt() to get
vba for this instruction.
The optimal is to keep parisc arch code as I did in v1 and don't change it too much.
Jason
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help