# Re: \[PATCH\] KVM: PPC: Fix misleading interrupts comment in kvmppc\_prepare\_to\_enter()

- From: Shrikanth Hegde \<sshegde@linux.ibm.com\>
- Date: 2025-08-07 04:45:37 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2025/08/9535871
- Thread: https://ratatoskr.run/linuxppc-dev/2025/08/9535869/t.md

```text


On 8/6/25 11:26, Andrew Donnellan wrote:
> Until commit 6c85f52b10fd ("kvm/ppc: IRQ disabling cleanup"),
> kvmppc_prepare_to_enter() was called with interrupts already disabled by
> the caller, which was documented in the comment above the function.
>
> Post-cleanup, the function is now called with interrupts enabled, and
> disables interrupts itself.
>
> Fix the comment to reflect the current behaviour.
>
> Fixes: 6c85f52b10fd ("kvm/ppc: IRQ disabling cleanup")
> Signed-off-by: Andrew Donnellan <redacted>

Given that there is WARN_ON which would trigger if IRQ were disabled
and further we flip irq before calling schedule, indicates that IRQ must be enabled while calling it.

Reviewed-by:: Shrikanth Hegde [ref]

```
