[PATCH net-next] net: phy: remove unused PHY_INIT_TIMEOUT definitions
Subsystems:
ethernet phy library , freescale quicc engine ucc ethernet driver , networking drivers , the rest
539d
3 messages,
2 authors,
2025-02-09
· open the first message on its own page
Both identical definitions of PHY_INIT_TIMEOUT aren't used,
so remove them.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/freescale/ucc_geth.h | 1 -
include/linux/phy.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.h b/drivers/net/ethernet/freescale/ucc_geth.h
index 38789faae..03b515240 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.h
+++ b/drivers/net/ethernet/freescale/ucc_geth.h @@ -890,7 +890,6 @@ struct ucc_geth_hardware_statistics {
addresses */
#define TX_TIMEOUT (1*HZ)
- #define PHY_INIT_TIMEOUT 100000 #define PHY_CHANGE_TIME 2
/* Fast Ethernet (10/100 Mbps) */ diff --git a/include/linux/phy.h b/include/linux/phy.h
index 3028f8abf..9cb86666c 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h @@ -293,7 +293,6 @@ static inline long rgmii_clock(int speed)
}
}
- #define PHY_INIT_TIMEOUT 100000 #define PHY_FORCE_TIMEOUT 10
#define PHY_MAX_ADDR 32 --
2.48.1
Le 08/02/2025 à 22:14, Heiner Kallweit a écrit : Both identical definitions of PHY_INIT_TIMEOUT aren't used,
so remove them.
Would be good to say when it stopped being used, ie which commit or
commits removed its use.
Also why only remove PHY_INIT_TIMEOUT ? For instance PHY_FORCE_TIMEOUT
also seems to be unused. PHY_CHANGE_TIME as well.
quoted hunk
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/freescale/ucc_geth.h | 1 -
include/linux/phy.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.h b/drivers/net/ethernet/freescale/ucc_geth.h
index 38789faae..03b515240 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.h
+++ b/drivers/net/ethernet/freescale/ucc_geth.h @@ -890,7 +890,6 @@ struct ucc_geth_hardware_statistics {
addresses */
#define TX_TIMEOUT (1*HZ)
- #define PHY_INIT_TIMEOUT 100000 #define PHY_CHANGE_TIME 2
/* Fast Ethernet (10/100 Mbps) */ diff --git a/include/linux/phy.h b/include/linux/phy.h
index 3028f8abf..9cb86666c 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h @@ -293,7 +293,6 @@ static inline long rgmii_clock(int speed)
}
}
- #define PHY_INIT_TIMEOUT 100000 #define PHY_FORCE_TIMEOUT 10
#define PHY_MAX_ADDR 32
On 09.02.2025 10:28, Christophe Leroy wrote:
Le 08/02/2025 à 22:14, Heiner Kallweit a écrit : quoted Both identical definitions of PHY_INIT_TIMEOUT aren't used,
so remove them.
Would be good to say when it stopped being used, ie which commit or commits removed its use.
Also why only remove PHY_INIT_TIMEOUT ? For instance PHY_FORCE_TIMEOUT also seems to be unused. PHY_CHANGE_TIME as well. I stumbled just across PHY_INIT_TIMEOUT. You're right, I will include other apparently unused
definitions as well.
quoted
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/freescale/ucc_geth.h | 1 -
include/linux/phy.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.h b/drivers/net/ethernet/freescale/ucc_geth.h
index 38789faae..03b515240 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.h
+++ b/drivers/net/ethernet/freescale/ucc_geth.h @@ -890,7 +890,6 @@ struct ucc_geth_hardware_statistics { addresses */
#define TX_TIMEOUT (1*HZ)
-#define PHY_INIT_TIMEOUT 100000
#define PHY_CHANGE_TIME 2
/* Fast Ethernet (10/100 Mbps) */ diff --git a/include/linux/phy.h b/include/linux/phy.h
index 3028f8abf..9cb86666c 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h @@ -293,7 +293,6 @@ static inline long rgmii_clock(int speed) }
}
-#define PHY_INIT_TIMEOUT 100000
#define PHY_FORCE_TIMEOUT 10
#define PHY_MAX_ADDR 32 --
pw-bot: cr