# Re: \[PATCH 1/3\] bitmap: remove \_check\_eq\_u32\_array

- From: David Gow \<hidden\>
- Date: 2025-02-08 09:07:19 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2025/02/2917705
- Thread: https://ratatoskr.run/linuxppc-dev/2025/02/2917214/t.md

```text
On Sat, 8 Feb 2025 at 04:14, Tamir Duberstein [ref] wrote:
>
> This has been unused since commit 3aa56885e516 ("bitmap: replace
> bitmap_{from,to}_u32array") in 2018. Remove it to avoid the need to port
> it to KUnit in this series.
>
> Signed-off-by: Tamir Duberstein <redacted>
> ---

Makes sense.

Reviewed-by: David Gow <redacted>

Cheers,
-- David


>  lib/test_bitmap.c | 28 ----------------------------
>  1 file changed, 28 deletions(-)
>
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 65a75d58ed9e..c83829ef557f 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -100,34 +100,6 @@ __check_eq_pbl(const char *srcfile, unsigned int line,
>         return true;
>  }
>
> -static bool __init
> -__check_eq_u32_array(const char *srcfile, unsigned int line,
> -                    const u32 *exp_arr, unsigned int exp_len,
> -                    const u32 *arr, unsigned int len) __used;
> -static bool __init
> -__check_eq_u32_array(const char *srcfile, unsigned int line,
> -                    const u32 *exp_arr, unsigned int exp_len,
> -                    const u32 *arr, unsigned int len)
> -{
> -       if (exp_len != len) {
> -               pr_warn("[%s:%u] array length differ: expected %u, got %u\n",
> -                       srcfile, line,
> -                       exp_len, len);
> -               return false;
> -       }
> -
> -       if (memcmp(exp_arr, arr, len*sizeof(*arr))) {
> -               pr_warn("[%s:%u] array contents differ\n", srcfile, line);
> -               print_hex_dump(KERN_WARNING, "  exp:  ", DUMP_PREFIX_OFFSET,
> -                              32, 4, exp_arr, exp_len*sizeof(*exp_arr), false);
> -               print_hex_dump(KERN_WARNING, "  got:  ", DUMP_PREFIX_OFFSET,
> -                              32, 4, arr, len*sizeof(*arr), false);
> -               return false;
> -       }
> -
> -       return true;
> -}
> -
>  static bool __init __check_eq_clump8(const char *srcfile, unsigned int line,
>                                     const unsigned int offset,
>                                     const unsigned int size,
>
> --
> 2.48.1
>
```

## Attachments

- [smime.p7s](https://ratatoskr.run/linuxppc-dev/2025/02/2917705/attachment/0) (application/pkcs7-signature, 5294 bytes)