[PATCH 0/2] Use helper function for_each_child_of_node()

Use for_each_child_of_node() to iterate through the device_node, this
can make code more simple.

Zhang Zekun (2):
  powerpc/powermac/pfunc_base: Use helper function
    for_each_child_of_node()
  powerpc/pseries/dlpar: Use helper function for_each_child_of_node()

 arch/powerpc/platforms/powermac/pfunc_base.c | 2 +-
 arch/powerpc/platforms/pseries/dlpar.c       | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

-- 
2.17.1

for_each_child_of_node can help to iterate through the device_node,
and we don't need to use while loop. No functional change with this
conversion.

Signed-off-by: Zhang Zekun <redacted>
---
 arch/powerpc/platforms/pseries/dlpar.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
index 47f8eabd1bee..ee47ed21b99d 100644
--- a/arch/powerpc/platforms/pseries/dlpar.c
+++ b/arch/powerpc/platforms/pseries/dlpar.c

@@ -250,11 +250,8 @@ int dlpar_detach_node(struct device_node *dn)
 	struct device_node *child;
 	int rc;
 
-	child = of_get_next_child(dn, NULL);
-	while (child) {
+	for_each_child_of_node(dn, child)
 		dlpar_detach_node(child);
-		child = of_get_next_child(dn, child);
-	}
 
 	rc = of_detach_node(dn);
 	if (rc)

-- 
2.17.1

for_each_child_of_node() can help to iterate through the device_node,
and we don't need to do it manually. No functional change with this
conversion.

Signed-off-by: Zhang Zekun <redacted>
---
 arch/powerpc/platforms/powermac/pfunc_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powermac/pfunc_base.c b/arch/powerpc/platforms/powermac/pfunc_base.c
index 085e0ad20eba..8253de737373 100644
--- a/arch/powerpc/platforms/powermac/pfunc_base.c
+++ b/arch/powerpc/platforms/powermac/pfunc_base.c

@@ -313,7 +313,7 @@ static void __init uninorth_install_pfunc(void)
 	/*
 	 * Install handlers for the hwclock child if any
 	 */
-	for (np = NULL; (np = of_get_next_child(uninorth_node, np)) != NULL;)
+	for_each_child_of_node(uninorth_node, np)
 		if (of_node_name_eq(np, "hw-clock")) {
 			unin_hwclock = np;
 			break;

-- 
2.17.1

On Thu, 22 Aug 2024 16:54:28 +0800, Zhang Zekun wrote:

Use for_each_child_of_node() to iterate through the device_node, this
can make code more simple.

Zhang Zekun (2):
  powerpc/powermac/pfunc_base: Use helper function
    for_each_child_of_node()
  powerpc/pseries/dlpar: Use helper function for_each_child_of_node()

[...]

Applied to powerpc/next.

[1/2] powerpc/powermac/pfunc_base: Use helper function for_each_child_of_node()
      https://git.kernel.org/powerpc/c/197116e2dec8d23888ce76044fe673480afceff0
[2/2] powerpc/pseries/dlpar: Use helper function for_each_child_of_node()
      https://git.kernel.org/powerpc/c/46f4bbb8aac2b876355cdefdacd1971b65f8b631

cheers