# Re: \[PATCH\] powerpc/xmon: Fix tmpstr length check in scanhex

- From: Madhavan Srinivasan \<maddy@linux.ibm.com\>
- Date: 2024-08-14 10:28:57 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2024/08/9534440
- Thread: https://ratatoskr.run/linuxppc-dev/2024/08/9534439/t.md

```text

On 8/14/24 3:53 PM, Miguel Ojeda wrote:
> On Wed, Aug 14, 2024 at 12:10 PM Madhavan Srinivasan
> [ref] wrote:
>> Reported-by: Miguel Ojeda <redacted>
>> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
>> Link - https://lore.kernel.org/linuxppc-dev/87ilc8ym6v.fsf@mail.lhotse/
> Thanks for fixing this!
>
> The "Link -" should be a tag, i.e. "Link:". And, in this case, since
> it was a report, I think it should be a "Closes:" instead, and thus it
> should be put below the "Reported-by:" and it should point to the
> message of the original report, i.e.
>
>      https://lore.kernel.org/linuxppc-dev/CANiq72=QeTgtZL4k9=4CJP6C_Hv=rh3fsn3B9S3KFoPXkyWk3w@mail.gmail.com/


Ok thats was fast :)
Thanks for the review,  Will fix it in v2 and also will check and add "Fixes" tag part.

Maddy

>
> I am not sure if a "Fixes:" tag would apply here, though.
>
> Cheers,
> Miguel

```
