[PATCH] bus: fsl-mc: make fsl_mc_bus_type const

Subsystems: freescale soc drivers, qoriq dpaa2 fsl-mc bus driver, the rest

STALE708d LANDED

Landed in mainline as 8ab0f4605d5c on 2024-09-03.

2 messages, 2 authors, 2024-08-23 · open the first message on its own page

[PATCH] bus: fsl-mc: make fsl_mc_bus_type const

From: Kunwu Chan <hidden>
Date: 2024-08-23 06:24:58

From: Kunwu Chan <redacted>

Since commit d492cc2573a0 ("driver core: device.h: make struct
bus_type a const *"), the driver core can properly handle constant
struct bus_type, move the fsl_mc_bus_type variable to be a constant
structure as well, placing it into read-only memory which can not be
modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kunwu Chan <redacted>
---
 drivers/bus/fsl-mc/fsl-mc-bus.c | 2 +-
 include/linux/fsl/mc.h          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
index dd68b8191a0a..930d8a3ba722 100644
--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -309,7 +309,7 @@ static struct attribute *fsl_mc_bus_attrs[] = {
 
 ATTRIBUTE_GROUPS(fsl_mc_bus);
 
-struct bus_type fsl_mc_bus_type = {
+const struct bus_type fsl_mc_bus_type = {
 	.name = "fsl-mc",
 	.match = fsl_mc_bus_match,
 	.uevent = fsl_mc_bus_uevent,
diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
index 083c860fd28e..c90ec889bfc2 100644
--- a/include/linux/fsl/mc.h
+++ b/include/linux/fsl/mc.h
@@ -436,7 +436,7 @@ void fsl_mc_free_irqs(struct fsl_mc_device *mc_dev);
 struct fsl_mc_device *fsl_mc_get_endpoint(struct fsl_mc_device *mc_dev,
 					  u16 if_id);
 
-extern struct bus_type fsl_mc_bus_type;
+extern const struct bus_type fsl_mc_bus_type;
 
 extern struct device_type fsl_mc_bus_dprc_type;
 extern struct device_type fsl_mc_bus_dpni_type;
-- 
2.43.0

Re: [PATCH] bus: fsl-mc: make fsl_mc_bus_type const

From: Christophe Leroy <hidden>
Date: 2024-08-23 17:00:32


Le 23/08/2024 à 08:24, Kunwu Chan a écrit :
[Vous ne recevez pas souvent de courriers de kunwu.chan@linux.dev. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]

From: Kunwu Chan <redacted>

Since commit d492cc2573a0 ("driver core: device.h: make struct
bus_type a const *"), the driver core can properly handle constant
struct bus_type, move the fsl_mc_bus_type variable to be a constant
structure as well, placing it into read-only memory which can not be
modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kunwu Chan <redacted>
Acked-by: Christophe Leroy <redacted> # for 
include/linux/fsl/mc.h
quoted hunk
---
  drivers/bus/fsl-mc/fsl-mc-bus.c | 2 +-
  include/linux/fsl/mc.h          | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
index dd68b8191a0a..930d8a3ba722 100644
--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -309,7 +309,7 @@ static struct attribute *fsl_mc_bus_attrs[] = {

  ATTRIBUTE_GROUPS(fsl_mc_bus);

-struct bus_type fsl_mc_bus_type = {
+const struct bus_type fsl_mc_bus_type = {
         .name = "fsl-mc",
         .match = fsl_mc_bus_match,
         .uevent = fsl_mc_bus_uevent,
diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
index 083c860fd28e..c90ec889bfc2 100644
--- a/include/linux/fsl/mc.h
+++ b/include/linux/fsl/mc.h
@@ -436,7 +436,7 @@ void fsl_mc_free_irqs(struct fsl_mc_device *mc_dev);
  struct fsl_mc_device *fsl_mc_get_endpoint(struct fsl_mc_device *mc_dev,
                                           u16 if_id);

-extern struct bus_type fsl_mc_bus_type;
+extern const struct bus_type fsl_mc_bus_type;

  extern struct device_type fsl_mc_bus_dprc_type;
  extern struct device_type fsl_mc_bus_dpni_type;
--
2.43.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help