Re: [PATCH v3 12/15] mm/memory: pass PTE to copy_present_pte()
From: Mike Rapoport <rppt@kernel.org>
Date: 2024-02-08 06:27:49
Also in:
linux-arm-kernel, linux-mm, linux-riscv, linux-s390, lkml, sparclinux
On Mon, Jan 29, 2024 at 01:46:46PM +0100, David Hildenbrand wrote:
We already read it, let's just forward it. This patch is based on work by Ryan Roberts. Reviewed-by: Ryan Roberts <ryan.roberts@arm.com> Signed-off-by: David Hildenbrand <redacted>
Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
quoted hunk ↗ jump to hunk
--- mm/memory.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)diff --git a/mm/memory.c b/mm/memory.c index a3bdb25f4c8d..41b24da5be38 100644 --- a/mm/memory.c +++ b/mm/memory.c@@ -959,10 +959,9 @@ static inline void __copy_present_pte(struct vm_area_struct *dst_vma, */ static inline int copy_present_pte(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, - pte_t *dst_pte, pte_t *src_pte, unsigned long addr, int *rss, - struct folio **prealloc) + pte_t *dst_pte, pte_t *src_pte, pte_t pte, unsigned long addr, + int *rss, struct folio **prealloc) { - pte_t pte = ptep_get(src_pte); struct page *page; struct folio *folio;@@ -1103,7 +1102,7 @@ copy_pte_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, } /* copy_present_pte() will clear `*prealloc' if consumed */ ret = copy_present_pte(dst_vma, src_vma, dst_pte, src_pte, - addr, rss, &prealloc); + ptent, addr, rss, &prealloc); /* * If we need a pre-allocated page for this pte, drop the * locks, allocate, and try again.-- 2.43.0
-- Sincerely yours, Mike.